Re: [Buildroot] [PATCH 1/1] package/python-msgpack: fix build without cpp toolchain

["Yann E. MORIN" <yann.morin.1998@free.fr>]

James, All,

On 2023-11-26 13:33 -0700, James Hilliard spake thusly:
> Prior to being updated to version 1.0.7 in
> 014a66fcde68bd0b612b62ec722ccc93bdc0d7f9 python-msgpack would
> automatically fall back to the pure python version if the cpp based
> optimized extension would fail to build for any reason.
> 
> This however is no longer the case after updating to 1.0.7 where it
> is now required that we explicitely set the MSGPACK_PUREPYTHON=1 if
> we do not have cpp support enabled in the toolchain.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/361/36185a19bed4bd57421a4d909bce1976c89d130f
>  - http://autobuild.buildroot.net/results/477/477f822cb196ebc2246bcbdc1b6eaf940fc018cd
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/python-msgpack/python-msgpack.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/python-msgpack/python-msgpack.mk b/package/python-msgpack/python-msgpack.mk
> index 061ff5a761..82110b1776 100644
> --- a/package/python-msgpack/python-msgpack.mk
> +++ b/package/python-msgpack/python-msgpack.mk
> @@ -11,4 +11,8 @@ PYTHON_MSGPACK_LICENSE = Apache-2.0
>  PYTHON_MSGPACK_LICENSE_FILES = COPYING
>  PYTHON_MSGPACK_SETUP_TYPE = setuptools
>  
> +ifeq ($(BR2_INSTALL_LIBSTDCPP),)
> +PYTHON_MSGPACK_ENV = MSGPACK_PUREPYTHON=1
> +endif

As you explained on IRC, the value we set it to does not matter:
whatever the value (even empty!), it forces to use pure python code.
I.e. there is no way to force it to use C++.

Applied to master with a comment explaining that, thanks.

Regards,
Yann E. MORIN.

>  $(eval $(python-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot