Re: [Buildroot] [PATCH 1/1] package/attr: add --enable-multilib to fix build error for BL808 based boards

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: leow149 <info.leo@widler.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/attr: add --enable-multilib to fix build error for BL808 based boards
Date: Sun, 26 Nov 2023 22:56:44 +0100	[thread overview]
Message-ID: <20231126215644.GO3177259@scaer> (raw)
In-Reply-To: <20231126214357.3376407-1-info.leo@widler.de>

leow149, All,

Thank you for your contribution! Here is a quick review.

First, we'll need you to use your real name as the author of the patch;
we do not accept annonymous (od pseduonymou) contributions.

On 2023-11-26 22:43 +0100, leow149 spake thusly:
> This commit fixes a build error which specifically happens for Bouffallo Labs BL808 based boards, but might also happen on other RiscV64 Boards.

Please wrap your commit log to ~72 chars.

Waht is the error that you see? Could you see if there is a similar
build failure on out autobulders:
    http://autobuild.buildroot.org/?static=1&reason=attr-%

The last build error for attr was more than a year ago now, so it is
relatively surprising to see that attr does not build. So we'll need a
bit more context.

> Signed-off-by: leow149 <info.leo@widler.de>
> ---
>  package/attr/attr.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/attr/attr.mk b/package/attr/attr.mk
> index 0327497e1e..89f7d21f0c 100644
> --- a/package/attr/attr.mk
> +++ b/package/attr/attr.mk
> @@ -13,7 +13,8 @@ ATTR_CPE_ID_VENDOR = attr_project
>  
>  ATTR_INSTALL_STAGING = YES
>  
> -ATTR_CONF_OPTS = --disable-nls
> -
> +ATTR_CONF_OPTS = \
> +	--disable-nls \
> +	--enable-multilib

Buildroot does not generate multilib toolchains, and when using an
external toolchain that is multilib, the proper multilib diretory is
copies over to the sysroot.

So, --eanble-multilib looksa like the wrong approach, at least without
more explanations.

Can you elaborate on the issue you encounter, and what makes you think
--enable-multilib is the correct solution?

Thanks!

Regards,
Yann E. MORIN.

>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot