Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Petr Vorel <pevik@seznam.cz>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/nfs-utils: fix build failure due to glibc <= 2.24
Date: Sun, 3 Dec 2023 22:56:13 +0100	[thread overview]
Message-ID: <20231203215613.GA6418@pevik> (raw)
In-Reply-To: <20231127170918.GS3177259@scaer>

> Petr, All,

> On 2023-11-16 21:16 +0100, Petr Vorel spake thusly:
> > From: Petr Vorel <petr.vorel@gmail.com>

> > Backport upstream patches that check if <sys/random.h> exists or not. If
> > it doesn't exist it uses uses the corresponding syscall.

> > NOTE: This would not be enough on Linux kernel < 3.17, but that's old
> > enough.

> I guess that's about kernel headers, i.e. that would cause a build
> filure, not a runtime one?

> If so, that would need a dependency on kern el headers;

>     depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17

Thank you, sure, I'll add it in v2.

> > Fixes: http://autobuild.buildroot.net/results/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/
> > Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> > ---
> > Hi,

> > I'm sorry for the noise (I sent unsubscribed).

> > NOTE: I was not able to test the build, therefore it *should* fix it.

> Giulio reported build failures with this patch applied, and also:

Yes, Giulio reported it to me as well. I plan to fix this issue in upstream
first. Unfortunately I'm very busy now, I hope I'll get to this soon.

> [--SNIP--]
> > diff --git a/package/nfs-utils/0003-reexport-fsidd.c-Remove-unused-headers.patch b/package/nfs-utils/0003-reexport-fsidd.c-Remove-unused-headers.patch
> > new file mode 100644
> > index 0000000000..0331a8c9f8
> > --- /dev/null
> > +++ b/package/nfs-utils/0003-reexport-fsidd.c-Remove-unused-headers.patch
> > @@ -0,0 +1,42 @@
> > +From 1a4edb2aa6b9b88fcdcb8d82b262467d06527623 Mon Sep 17 00:00:00 2001
> > +From: Petr Vorel <pvorel@suse.cz>
> > +Date: Fri, 10 Nov 2023 10:35:33 -0500
> > +Subject: [PATCH 1/3] reexport/fsidd.c: Remove unused headers

>     $ make check-package
>     package/nfs-utils/0003-reexport-fsidd.c-Remove-unused-headers.patch:4: generate your patches with 'git format-patch -N'
>     package/nfs-utils/0004-support-reexport.c-Remove-unused-headers.patch:4: generate your patches with 'git format-patch -N'
>     package/nfs-utils/0005-support-backend_sqlite.c-Add-getrandom-fallback.patch:4: generate your patches with 'git format-patch -N'

And I will fix this as well.

Kind regards,
Petr

> Regards,
> Yann E. MORIN.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-12-03 21:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 20:16 [Buildroot] [PATCH 1/1] package/nfs-utils: fix build failure due to glibc <= 2.24 Petr Vorel
2023-11-27 17:09 ` Yann E. MORIN
2023-12-03 21:56   ` Petr Vorel [this message]
     [not found] <20231116192104.2618421-1-pevik@seznam.cz>
2023-11-16 21:49 ` Giulio Benetti
     [not found]   ` <CAB1t1Cw8gJ+r64niKMymhvem9jdpVASC4fa4qEuDj5+4sp2HCQ@mail.gmail.com>
2023-11-17 10:27     ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231203215613.GA6418@pevik \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=pevik@seznam.cz \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox