Re: [Buildroot] [autobuild.buildroot.net] Your daily results for 2023-11-29

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Alex,

The best strategy is to remove the stupid asm("nop") that are in this
library code.

Best regards,

Thomas Petazzoni

On Thu, 30 Nov 2023 14:43:33 +0000
Michel Alex <Alex.Michel@wiedemann-group.com> wrote:

> Hello Thomas,
> 
> thanks for your reply.
> 
> What is the best strategy to fix this build error? To exclude ar1k architecture for this library (disable it if ar1k is selected) or to provide a patch which just removes the corresponding line?
> 
> Best regards,
> Alex
> 
> -----Original Message-----
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com> 
> Sent: Thursday, November 30, 2023 8:56 AM
> To: Michel Alex <Alex.Michel@wiedemann-group.com>
> Cc: buildroot@buildroot.org
> Subject: Re: [autobuild.buildroot.net] Your daily results for 2023-11-29
> 
> Vorsicht: Es handelt sich um eine externe E-Mail vom Absender Thomas Petazzoni <thomas.petazzoni@bootlin.com>. Bitte klicken Sie nicht auf Links oder Anhänge, solange Sie nicht von der Echtheit der Nachricht überzeugt sind.
> 
> Hello Alex,
> 
> The code in libzenoh-pico is stupid:
> 
> size_t _z_endpoint_config_strlen(const _z_str_intmap_t *s, const char *proto) {
>     size_t len = 0;
> 
>     // Call the right configuration parser depending on the protocol #if Z_LINK_TCP == 1
>     if (_z_str_eq(proto, TCP_SCHEMA) == true) {
>         len = _z_tcp_config_strlen(s);
>     } else
> #endif
> #if Z_LINK_UDP_UNICAST == 1 || Z_LINK_UDP_MULTICAST == 1
>         if (_z_str_eq(proto, UDP_SCHEMA) == true) {
>         len = _z_udp_config_strlen(s);
>     } else
> #endif
> #if Z_LINK_BLUETOOTH == 1
>         if (_z_str_eq(proto, BT_SCHEMA) == true) {
>         len = _z_bt_config_strlen(s);
>     } else
> #endif
> #if Z_LINK_SERIAL == 1
>         if (_z_str_eq(proto, SERIAL_SCHEMA) == true) {
>         len = _z_serial_config_strlen(s);
>     } else
> #endif
> #if Z_LINK_WS == 1
>         if (_z_str_eq(proto, WS_SCHEMA) == true) {
>         len = _z_ws_config_strlen(s);
>     } else
> #endif
>     {
>         __asm__("nop");
>     }
> 
>     return len;
> }
> 
> See the __asm__("nop"). This is completely stupid. It assumes every CPU architecture in the world has a CPU instruction named "nop", which of course is not true. I don't really see what they have added that, it really doesn't make sense. I believe this final "else" block should be dropped (as well as in the next function, that uses the same pattern).
> 
> Best regards,
> 
> Thomas
> 
> On Thu, 30 Nov 2023 07:34:37 +0000
> Michel Alex <Alex.Michel@wiedemann-group.com> wrote:
> 
> > Thomas,
> > 
> > do you have any idea how to fix this build error?
> > 
> > Error: unrecognized instruction `nop'
> > 
> > Alex
> > 
> > -----Original Message-----
> > From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Sent: Thursday, November 30, 2023 7:38 AM
> > To: Michel Alex <Alex.Michel@wiedemann-group.com>
> > Subject: [autobuild.buildroot.net] Your daily results for 2023-11-29
> > 
> > 
> > Hello,
> > 
> > Autobuilder failures
> > ====================
> > 
> > Below is a list of build failures reported by the Buildroot autobuilders in relation to packages or CPU architectures you are in charge of.
> > Please help us improving the quality of Buildroot by investigating those build failures and sending patches to fix them.
> > 
> > Results for the 'master' branch
> > -------------------------------
> > 
> > Build failures related to your packages:
> > 
> >     arch     |             reason             |                                       url                                      
> > -------------+--------------------------------+-----------------------
> > -------------+--------------------------------+--
> > -------------+--------------------------------+-----------------------
> > -------------+--------------------------------+--
> > -------------+--------------------------------+-----------------------
> > -------------+--------------------------------+--
> > -------------+--------------------------------+------
> >     or1k     |    libzenoh-pico-0.10.0-rc     | http://autobuild.buildroot.net/results/663b631810b7e3982f35539f5d388cf5e5090654
> > 
> > 
> > Thanks for your contribution to Buildroot!
> > 
> > --
> > http://autobuild.buildroot.net  
> 
> 
> 
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com



-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot