Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: buildroot@buildroot.org,
	Kilian Zinnecker <kilian.zinnecker@mail.de>,
	yann.morin.1998@free.fr
Subject: Re: [Buildroot] Buildroot docker image
Date: Sun, 10 Dec 2023 13:17:02 +0100	[thread overview]
Message-ID: <20231210131702.76975e38@windsurf> (raw)
In-Reply-To: <a6f09f61-573b-465a-b5a9-6d175c313f2b@mind.be>

On Sat, 9 Dec 2023 22:29:32 +0100
Arnout Vandecappelle <arnout@mind.be> wrote:

>   So, if we do go for Alpine as the official docker image, we can expect quite a 
> lot of breakage... Therefore, before going there, I think we should go for a 
> "normal" distro after all for the time being. Of all the traditional distros, 
> ubuntu:22.04 has by far the smallest image at 80MB (this actually came as quite 
> the surprise to me... I have no idea why Fedora would be twice as large! But it 
> does already include Python, so after installing all necessary packages it may 
> even out again...).

An advantage of Fedora is that their Perl packaging is much more
fine-grained than in Debian/Ubuntu, which allows us to better detect
when we have missing Perl modules.

> > +RUN apk add --no-cache bc  
> 
>   Actually, we check for bc, but I don't think it's needed for anything... The 
> alpine container is a good way to test for this kind of stuff (all normal build 
> machines will have bc installed for other reasons).

I think bc is needed to build the Linux kernel, and we don't build
host-bc as a dependency of the linux package.


> > +USER root
> > +WORKDIR /home/br-user
> > +ADD https://github.com/buildroot/buildroot/archive/refs/heads/master.tar.gz /  
> 
>   Don't use the github mirror, use the actual upstream:
> http://gitlab.com/buildroot.org/buildroot
> 
>   However, I don't think we should pull the repository here. Instead, we should 
> use the already-checked-out buildroot from which this Dockerfile is built. Or we 
> shouldn't have any buildroot source in the container and just mount the volume, 
> like is done in docker-run.
> 
> > home/br-user/buildroot.tar.gz
> > +RUN chown -R br-user /home/br-user
> > +RUN chgrp -R br-user /home/br-user  
> 
>   You can do chown -R br-user.br-user to do both at the same time.

[...]

What is the goal of this new Dockerfile, compared to the one we already
have at support/docker/Dockerfile ?

support/docker/Dockerfile already has a good setup in terms of how the
br-user should be created, what the Dockerfile should use, etc. Why
should we do things differently?

I had one two things to suggest improving compared to our existing
Dockerfile:

- We should have a more minimal Dockerfile that installs really the
  strict minimal requirements that Buildroot needs to do a build, and
  then a second Dockerfile than inherits from the first, and adding
  what's needed so that it can be used as our CI Docker

- We should similarly have combos of Docker file (one minimal, one CI)
  that use different distributions;

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-12-10 12:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01  6:51 [Buildroot] Buildroot docker image Kilian Zinnecker via buildroot
2023-09-01  7:19 ` Arnout Vandecappelle via buildroot
2023-09-02  7:42   ` Thomas Petazzoni via buildroot
2023-12-03 11:47     ` Kilian Zinnecker via buildroot
2023-12-09 21:29       ` Arnout Vandecappelle via buildroot
2023-12-10 12:17         ` Thomas Petazzoni via buildroot [this message]
2023-12-10 19:28         ` Peter Korsgaard
2023-12-10 13:48     ` Yann E. MORIN
2023-12-10 13:51       ` Yann E. MORIN
2023-12-10 17:02       ` Thomas Petazzoni via buildroot
2023-12-10 18:46         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231210131702.76975e38@windsurf \
    --to=buildroot@buildroot.org \
    --cc=arnout@mind.be \
    --cc=kilian.zinnecker@mail.de \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox