From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Baruch Siach via buildroot <buildroot@buildroot.org>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH] package/libcurl: fix build with GnuTLS and no verbose
Date: Sun, 17 Dec 2023 22:43:11 +0100 [thread overview]
Message-ID: <20231217224311.57b7bad3@windsurf> (raw)
In-Reply-To: <dc1be561d66161495c91667e02c816e6d48880ac.1702320987.git.baruch@tkos.co.il>
On Mon, 11 Dec 2023 20:56:27 +0200
Baruch Siach via buildroot <buildroot@buildroot.org> wrote:
> diff --git a/package/libcurl/0001-gnutls-fix-build-with-disable-verbose.patch b/package/libcurl/0001-gnutls-fix-build-with-disable-verbose.patch
> new file mode 100644
> index 000000000000..cc7f89f9762c
> --- /dev/null
> +++ b/package/libcurl/0001-gnutls-fix-build-with-disable-verbose.patch
> @@ -0,0 +1,33 @@
> +From 3b1ed6573bbb95831e5acd01ecac95f2cb2b9a60 Mon Sep 17 00:00:00 2001
> +From: Baruch Siach <baruch@tkos.co.il>
> +Date: Mon, 11 Dec 2023 20:45:01 +0200
> +Subject: [PATCH] gnutls: fix build with --disable-verbose
> +
> +infof() parameters must be defined event with --disable-verbose since
> +commit dac293cfb702 ("lib: apache style infof and trace
> +macros/functions").
> +
> +Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> +Upstream: https://github.com/curl/curl/pull/12505
From what I can see at https://github.com/curl/curl/pull/12505, it
seems like your patch has been merged, but you changed it compared to
what you submitted here.
Could you submit an updated patch to Buildroot, which adds the upstream
applied version of your fix?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-12-17 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 18:56 [Buildroot] [PATCH] package/libcurl: fix build with GnuTLS and no verbose Baruch Siach via buildroot
2023-12-17 21:43 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231217224311.57b7bad3@windsurf \
--to=buildroot@buildroot.org \
--cc=buildroot@busybox.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox