Re: [Buildroot] [PATCH 1/2] python-sip: fix compile error

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Ralf Dragon <hypnotoad@lindra.de>
Cc: gwenhael.goavec-merou@trabucayre.com, yann.morin.1998@free.fr,
	asafka7@gmail.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] python-sip: fix compile error
Date: Sun, 17 Dec 2023 23:03:03 +0100	[thread overview]
Message-ID: <20231217230303.3200b052@windsurf> (raw)
In-Reply-To: <20231212160112.94272-1-hypnotoad@lindra.de>

Hello Ralf,

Thanks for the patch! I have applied it, with some changes, see below.

On Tue, 12 Dec 2023 17:01:11 +0100
Ralf Dragon <hypnotoad@lindra.de> wrote:

> Without the patch, python-sip fails to compile with:
> 
> siplib.c: In function ‘sip_api_get_frame’:
> siplib.c:13750:22: error: invalid use of undefined type ‘struct _frame’
> 13750 |         frame = frame->f_back;
> 
> This likely fixes bug 15201 [1].
> 
> [1] https://bugs.buildroot.org/show_bug.cgi?id=15201

I am not sure it fixes this bug. This bug is more about upgrading
python-sip, which indeed would be very nice to do as SIP 4.x is no
longer maintained, as you pointed out.

However, your patch fixes
http://autobuild.buildroot.net/results/7b01739e7514e48c06182bc1804b32497ce2e414/
for sure, so I've used that in the commit log.

> diff --git a/package/python-sip/0002-fixframe.patch b/package/python-sip/0002-fixframe.patch
> new file mode 100644
> index 0000000000..befe76fc73
> --- /dev/null
> +++ b/package/python-sip/0002-fixframe.patch
> @@ -0,0 +1,55 @@
> +siplib: fix build with python >= 3.11
> +
> +With python 3.11, the PyFrameObject structure members have been
> +removed from the public C API:
> +
> +https://docs.python.org/3.11/whatsnew/3.11.html#whatsnew311-c-api-porting
> +https://docs.python.org/3.11/whatsnew/3.11.html#pyframeobject-3-11-hiding
> +
> +This patch migrates to the opaque PyFrameObject.
> +
> +Signed-off-by: Ralf Dragon <hypnotoad@lindra.de>
> +Upstream: N/A as SIP v4 is no longer supported. 4.19.25 is the last release.

I reformatted this patch using "git format-patch" to be like patch
0001. I also slightly improved the commit log.

See the final commit:

  https://gitlab.com/buildroot.org/buildroot/-/commit/3ef6884e6d59744d83649170822a4829eed146fc

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot