From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>,
Asaf Kahlon <asafka7@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/4] package/python-pyproject-metadata: new host package
Date: Wed, 20 Dec 2023 21:59:31 +0100 [thread overview]
Message-ID: <20231220215931.354467ee@windsurf> (raw)
In-Reply-To: <20231125013807.213822-1-james.hilliard1@gmail.com>
On Fri, 24 Nov 2023 18:38:04 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> .../python-pyproject-metadata.hash | 5 +++++
> .../python-pyproject-metadata.mk | 14 ++++++++++++++
> 2 files changed, 19 insertions(+)
> create mode 100644 package/python-pyproject-metadata/python-pyproject-metadata.hash
> create mode 100644 package/python-pyproject-metadata/python-pyproject-metadata.mk
I have applied the entire series, but to be honest, your patches could
REALLY use some more detailed commit log. I had to research in the code
of python-meson-python why it needed host-patchelf. It sounded a bit
odd at first sight to see this dependency in such a package. It would
tremendously help the review process, and increase the confidence in
the patches if you could provide a bit of background information.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-12-20 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 1:38 [Buildroot] [PATCH 1/4] package/python-pyproject-metadata: new host package James Hilliard
2023-11-25 1:38 ` [Buildroot] [PATCH 2/4] package/python-meson-python: " James Hilliard
2023-11-25 1:38 ` [Buildroot] [PATCH 3/4] package/python-contourpy: new package James Hilliard
2023-11-25 1:38 ` [Buildroot] [PATCH 4/4] package/python-matplotlib: bump to version 3.8.2 James Hilliard
2023-12-20 20:59 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220215931.354467ee@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=eric.le.bihan.dev@free.fr \
--cc=james.hilliard1@gmail.com \
--cc=jugurtha.belkalem@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox