From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 06/14] package/libutempter: new package
Date: Wed, 20 Dec 2023 23:40:05 +0100 [thread overview]
Message-ID: <20231220234005.168dda27@windsurf> (raw)
In-Reply-To: <20231218194001.544887-6-adam.duskett@amarulasolutions.com>
On Mon, 18 Dec 2023 12:39:51 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
Applied after fixing two small things, see below. But now that I'm
re-reading, I found another issue.
> diff --git a/package/libutempter/Config.in b/package/libutempter/Config.in
> new file mode 100644
> index 0000000000..a06a240418
> --- /dev/null
> +++ b/package/libutempter/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_LIBUTEMPTER
> + bool "libutempter"
> + help
> + The libutempter library provides interface for terminal
> + emulators such as screen and xterm to record user
> + sessions to utmp and wtmp files.
> +
> + http://ftp.altlinux.org/pub/people/ldv/utempter/
> +
> +comment "libutempter needs a toolchain w/ headers >= 4.14, dynamic library"
> + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 || BR2_STATIC_LIBS
Really? The package has no "depends on". Which one is correct? The
Config.in comment, or the absence of "depends on". Could you send a patch to fix this?
> +LIBUTEMPTER_VERSION = 1.2.1
> +LIBUTEMPTER_SITE = ftp.altlinux.org/pub/people/ldv/utempter
> +LIBUTEMPTER_INSTALL_STAGING = YES
> +LIBUTEMPTER_LICENSE = LGPL-2.1
This was LGPL-2.1+
> +LIBUTEMPTER_LICENSE_FILES = COPYING
> +
> +define LIBUTEMPTER_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
> +endef
> +
> +define LIBUTEMPTER_INSTALL_STAGING_CMDS
> + $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) \
> + $(MAKE) DESTDIR=$(STAGING_DIR) PREFIX=/usr -C $(@D)/ install
One too many tab of indentation here.
> +endef
> +
> +define LIBUTEMPTER_INSTALL_TARGET_CMDS
> + $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) \
> + $(MAKE) DESTDIR=$(TARGET_DIR) PREFIX=/usr -C $(@D)/ install
And here as well.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-12-20 22:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 19:39 [Buildroot] [PATCH v2 01/14] package/sway/Config.in: Remove duplicate dependencies Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 02/14] package/sway/Config.in: select BR2_PACKAGE_XKEYBOARD_CONFIG Adam Duskett
2023-12-20 21:14 ` Thomas Petazzoni via buildroot
2024-01-07 17:34 ` Peter Korsgaard
2023-12-18 19:39 ` [Buildroot] [PATCH v2 03/14] package/dmenu-wayland: new package Adam Duskett
2023-12-20 22:07 ` Thomas Petazzoni via buildroot
2023-12-18 19:39 ` [Buildroot] [PATCH v2 04/14] package/tllist: " Adam Duskett
2023-12-20 22:11 ` Thomas Petazzoni via buildroot
2023-12-18 19:39 ` [Buildroot] [PATCH v2 05/14] package/fcft: " Adam Duskett
2023-12-20 22:22 ` Thomas Petazzoni via buildroot
2023-12-18 19:39 ` [Buildroot] [PATCH v2 06/14] package/libutempter: " Adam Duskett
2023-12-20 22:40 ` Thomas Petazzoni via buildroot [this message]
2023-12-18 19:39 ` [Buildroot] [PATCH v2 07/14] package/foot: " Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 08/14] package/ncurses: install foot terminfo if foot is selected Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 09/14] package/sway: enable bash-completion support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 10/14] package/sway: enable default-wallpaper support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 11/14] package/sway: enable swaybar support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 12/14] package/sway: enable swaybar tray support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 13/14] package/sway: enable swaynag support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 14/14] package/sway/Config.in: Add a help note about the default terminal Adam Duskett
2023-12-20 21:06 ` [Buildroot] [PATCH v2 01/14] package/sway/Config.in: Remove duplicate dependencies Thomas Petazzoni via buildroot
2024-01-07 17:34 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220234005.168dda27@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox