From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/octave: add libreadline search prefix
Date: Sun, 24 Dec 2023 19:18:02 +0100 [thread overview]
Message-ID: <20231224191802.5aea90d4@windsurf> (raw)
In-Reply-To: <20231212214610.374636-1-ju.o@free.fr>
Hello Julien,
On Tue, 12 Dec 2023 22:46:10 +0100
Julien Olivain <ju.o@free.fr> wrote:
> Since commit b36e4b10f3 "package/octave: bump to version 8.1.0",
> Octave fails to find readline automatically if octave and readline
> packages are both enabled in Buildroot the configuration.
>
> The readline search prefix need to be explicitly passed during octave
> configuration. This commit adds this search prefix to fix this build
> issue.
>
> Fixes:
>
> checking for readline... (cached) no
> checking for readline/readline.h... (cached) yes
> checking for readline/history.h... (cached) yes
> configure: WARNING: I need GNU Readline 4.2 or later
> configure: error: this is fatal unless you specify --disable-readline
>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
This looked good and relevant, but I'm unable to reproduce the issue,
which probably means there is something more to this.
Build:
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_OCTAVE=y
BR2_PACKAGE_READLINE=y
# BR2_TARGET_ROOTFS_TAR is not set
with:
./utils/docker-run make octave
and it builds just fine, readline is properly detected as it should be.
For the sake of completeness, I also re-did this build on commit
b36e4b10f3, which is when Octave was bumped to 8.1.0, which you said
was the commit that introduced the issue. But it also builds fine.
Could you double check what was your failing configuration, maybe
investigate what is different to understand the root cause?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-12-24 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 21:46 [Buildroot] [PATCH 1/1] package/octave: add libreadline search prefix Julien Olivain
2023-12-24 18:18 ` Thomas Petazzoni via buildroot [this message]
2024-01-06 12:59 ` Julien Olivain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231224191802.5aea90d4@windsurf \
--to=buildroot@buildroot.org \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox