Re: [Buildroot] [PATCH] Config.in: rework BR2_DOWNLOAD_FORCE_CHECK_HASHES

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, 27 Dec 2023 18:18:02 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

>  > -comment "Forcing all downloads to have a valid hash needs a global patch and hash directory"
>  > -	depends on BR2_GLOBAL_PATCH_DIR = ""
>  > +	  With this option turned on, Buildroot will check hashes of
>  > +	  all packages, including those have use a custom version. In  
> 
> s/have use/that use/

Fixed.

>  > +	  order to provide hashes for such packages, additional hash
>  > +	  files can be placed into BR2_GLOBAL_PATCH_DIR directories.  
> 
> I guess it is really s/can be/must be/, E.G. the build fails if not
> done, right?

I am not sure, I guess this is really a linguistic difference here. To
me the hash files must not be placed, they can be placed, if needed.
No-one forces anyone to have those hash files, but if they are needed,
then indeed the only option today is to have them in the
BR2_GLOBAL_PATCH_DIR.

I will not complain if you insist on "must be".

> Maybe we should mention utils/add-custom-hashes to create such .hash
> files?

Good point, added.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot