Re: [Buildroot] [PATCH] configs/broadcom_northstar_defconfig: adjust DTS paths

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Rafał,

On Tue,  2 Jan 2024 11:42:58 +0100
Rafał Miłecki <zajec5@gmail.com> wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Starting with kernel release v6.5 ARM DTS files are placed in vendor
> subdirectories (Linux commit 724ba6751532 ("ARM: dts: Move .dts files to
> vendor sub-directories")).
> 
> This fixes:
> make[3]: *** No rule to make target 'arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dtb'.  Stop.
> make[2]: *** [Makefile:1384: bcm4708-smartrg-sr400ac.dtb] Error 2
> make[3]: *** No rule to make target 'arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dtb'.  Stop.
> make[2]: *** [Makefile:1384: bcm47094-luxul-xwr-3150-v1.dtb] Error 2
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Thanks for the patch! I was wondering when it got broken, and this made
be realize that this defconfig doesn't follow a best practice that we
normally apply to all our defconfigs: the kernel version being built
should not be a moving target, but be fixed in the defconfig.

So, I've applied your patch, but could you submit a follow-up patch
that sets a fixed kernel version, just like we do in all defconfigs? It
also means the kernel headers version of the toolchain should be fixed
(again, I encourage you to look at the numerous other defconfigs we
have for examples of this).

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot