Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Dominik Michael Rauh <dmrauh@posteo.de>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3, 1/2] package/gdal: giflib and qhull are mandatory
Date: Tue, 2 Jan 2024 22:44:43 +0100	[thread overview]
Message-ID: <20240102224443.132a88fe@windsurf> (raw)
In-Reply-To: <20240102204756.1666286-1-fontaine.fabrice@gmail.com>

On Tue,  2 Jan 2024 21:47:55 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> giflib and qhull are mandatory since the addition of the package in
> commit 1e64fa2956171cdc9d6e6c8896b4b589ce573513 and
> https://github.com/OSGeo/gdal/commit/cb136fc051341ab99579daae3c8d8246fe918a76
> 
> Indeed, as explained in above commit, internal (bundled) libraries will
> be used if GDAL_USE_GIF and GDAL_USE_QHULL are set to OFF
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3 (after review of Thomas Petazzoni):
>  - Update commit message with bundled library explanation

Thanks so much for extending the commit log to point out the part that
I was missing. I've applied both patches to master!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-01-02 21:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02 20:47 [Buildroot] [PATCH v3, 1/2] package/gdal: giflib and qhull are mandatory Fabrice Fontaine
2024-01-02 20:47 ` [Buildroot] [PATCH v3,2/2] package/gdal: bump to version 3.8.2 Fabrice Fontaine
2024-01-02 21:44 ` Thomas Petazzoni via buildroot [this message]
2024-01-12 17:13 ` [Buildroot] [PATCH v3, 1/2] package/gdal: giflib and qhull are mandatory Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240102224443.132a88fe@windsurf \
    --to=buildroot@buildroot.org \
    --cc=dmrauh@posteo.de \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox