Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/7] package/python-grpcio: new package
Date: Tue, 2 Jan 2024 23:40:34 +0100	[thread overview]
Message-ID: <20240102234034.7e3496c6@windsurf> (raw)
In-Reply-To: <20231214192439.259156-1-james.hilliard1@gmail.com>

On Thu, 14 Dec 2023 12:24:33 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/Config.in                        |  1 +
>  package/python-grpcio/Config.in          |  6 ++++++
>  package/python-grpcio/python-grpcio.hash |  5 +++++
>  package/python-grpcio/python-grpcio.mk   | 14 ++++++++++++++
>  4 files changed, 26 insertions(+)
>  create mode 100644 package/python-grpcio/Config.in
>  create mode 100644 package/python-grpcio/python-grpcio.hash
>  create mode 100644 package/python-grpcio/python-grpcio.mk

Thanks for this work, I have applied the entire patch series.

My main suggestion/comment/request is to add runtime tests in
support/testing/ for those packages. The effort to add those tests is
quite low, and they are really relevant for Python modules. Do you
think you could have a look at adding such tests?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2024-01-02 22:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 19:24 [Buildroot] [PATCH 1/7] package/python-grpcio: new package James Hilliard
2023-12-14 19:24 ` [Buildroot] [PATCH 2/7] package/python-grpcio-reflection: " James Hilliard
2023-12-14 19:24 ` [Buildroot] [PATCH 3/7] package/python-cachetools: " James Hilliard
2023-12-14 19:24 ` [Buildroot] [PATCH 4/7] package/python-google-auth: " James Hilliard
2023-12-14 19:24 ` [Buildroot] [PATCH 5/7] package/python-googleapis-common-protos: " James Hilliard
2023-12-14 19:24 ` [Buildroot] [PATCH 6/7] package/python-google-api-core: " James Hilliard
2023-12-14 19:24 ` [Buildroot] [PATCH 7/7] package/python-grpc-requests: " James Hilliard
2024-01-02 22:40 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240102234034.7e3496c6@windsurf \
    --to=buildroot@buildroot.org \
    --cc=asafka7@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox