Re: [Buildroot] [PATCH 1/2] package/python-sqlalchemy: bump version to 2.0.25

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Flávio,

Thanks a lot for your patch, I have applied it, but after fixing a few
small things. See below!

On Wed,  3 Jan 2024 11:28:30 -0300
Flávio Tapajós <flavio.tapajos@newtesc.com.br> wrote:

> diff --git a/package/python-sqlalchemy/Config.in b/package/python-sqlalchemy/Config.in
> index f7ec3a6ad4..f05fee7ab1 100644
> --- a/package/python-sqlalchemy/Config.in
> +++ b/package/python-sqlalchemy/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_PYTHON_SQLALCHEMY
>  	bool "python-sqlalchemy"
> +	select BR2_PACKAGE_PYTHON_TYPING_EXTENSIONS

This a runtime dependency only, we don't need it at build-time. We like
to document such dependencies like this:

	select BR2_PACKAGE_PYTHON_TYPING_EXTENSIONS # runtime

which helps document that it is normal for this dependency to be in
Config.in, but not in the .mk file.

> diff --git a/package/python-sqlalchemy/python-sqlalchemy.hash b/package/python-sqlalchemy/python-sqlalchemy.hash
> index 9f479d8f7b..6a894bee24 100644
> --- a/package/python-sqlalchemy/python-sqlalchemy.hash
> +++ b/package/python-sqlalchemy/python-sqlalchemy.hash
> @@ -1,5 +1,5 @@
>  # md5, sha256 from https://pypi.org/pypi/sqlalchemy/json
> -md5  52318b83e8931c5f5a459f54fe4be3e8  SQLAlchemy-1.4.42.tar.gz
> -sha256  177e41914c476ed1e1b77fd05966ea88c094053e17a85303c4ce007f88eff363  SQLAlchemy-1.4.42.tar.gz
> +sha256 a2c69a7664fb2d54b8682dd774c3b54f67f84fa123cf84dda2a5f40dcaa04e08  SQLAlchemy-2.0.25.tar.gz
> +md5 7abfc2972d7e16315c8b7492ea0e0fdb SQLAlchemy-2.0.25.tar.gz

Here you changed the ordering of the two lines, which adds a bit of
"noise" and it not really needed. You also broke the spacing of the
different fields: we want two spaces between each field (yes that's a
pure convention, but it allows things to be consistent between
packages). If you run "make check-package", or "./utils/check-package
package/python-sqlalchemy/*", it checks such minor coding style issues.

>  # Locally computed sha256 checksums
>  sha256  859ded25da34c1eb73e6e736df4c5f8ce3ed2ed5290663176f06e7720d9c9a20  LICENSE

The final issue was related to the LICENSE file: it has changed between
the old version of sqlalchemy and this new version, so the hash was no
longer correct. So I have updated the hash, but more importantly, I
have documented in the commit log why the hash changed.

With all those changes, the final commit looks like this:

  https://gitlab.com/buildroot.org/buildroot/-/commit/0f2f090892914e3b04ff217d1ea10cceafc70515

Thanks again for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot