Re: [Buildroot] [PATCH] ARC: Switch toolchain components to arc-2023.09-release

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alexey Brodkin via buildroot <buildroot@buildroot.org>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Romain Naour <romain.naour@gmail.com>,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	Waldemar Brodkorb <mail@waldemar-brodkorb.de>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH] ARC: Switch toolchain components to arc-2023.09-release
Date: Fri, 5 Jan 2024 09:36:44 +0100	[thread overview]
Message-ID: <20240105093644.50646ce4@windsurf> (raw)
In-Reply-To: <20240104171224.1469776-1-abrodkin@synopsys.com>

Hello Alexey,

On Thu,  4 Jan 2024 09:12:24 -0800
Alexey Brodkin via buildroot <buildroot@buildroot.org> wrote:

> With the most recent ARC GNU toolchain version released [1]
> we may switch to its stable and verified components for Buildroot's
> built-in toolchian.
> 
> And while for ARCompact (i.e. ARC700) & ARCv2 (ARC HS38 & HS48)
> processors upstream components work just fine, in this new release
> of ARC GNU toolchain we have also support for newer ARCv3 procesors.
> 
> And so that update is more of an enabler for introduction of ARCv3
> in the next series of patches.
> 
> [1] https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/tag/arc-2023.09-release
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Waldemar Brodkorb <mail@waldemar-brodkorb.de>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@gmail.com>

Thanks, applied, with one small change.

> -ifeq ($(BR2_GDB_VERSION_14)$(BR2_PACKAGE_GDB_DEBUGGER),yy)
> +# GDB fork from ARC GNU tools 2023.09 is based on GDB14 branch and so
> +# requires MPFR as well.
> +ifeq ($(BR2_GDB_VERSION_14)$(BR2_arc)$(BR2_PACKAGE_GDB_DEBUGGER),yy)

Changed to:

ifeq ($(BR2_GDB_VERSION_14)$(BR2_arc):$(BR2_PACKAGE_GDB_DEBUGGER),y:y)

I know BR2_GDB_VERSION_14 and BR2_arc are mutually exclusive for now,
but I prefer to make this clear here.

BTW, could you submit a patch that aligns gdb with binutils and gcc: we
should be able to chose an upstream version of gdb even on ARC, while
for now, the ARC special version is forced on ARC (note: perhaps it is
in another series from you, I haven't reviewed all of them yet).

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot