Re: [Buildroot] [PATCH 1/1] package/cups: fix build without gnutls

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Olivier Schonken <olivier.schonken@gmail.com>,
	Angelo Compagnucci <angelo.compagnucci@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/cups: fix build without gnutls
Date: Fri, 5 Jan 2024 13:46:56 +0100	[thread overview]
Message-ID: <20240105134656.100fbdc8@windsurf> (raw)
In-Reply-To: <20240105123519.90929-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Fri,  5 Jan 2024 13:35:19 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure without gnutls raised since bump to
> version 2.4.7 in commit 55c80fdfb379c74c7f7e8c260dea02e0150d7614 and
> https://github.com/OpenPrinting/cups/commit/b5b1418da7bfb9f81384c7c47cc59890b4d3ff5d
> 
> hash.c:16:12: fatal error: gnutls/crypto.h: No such file or directory
>    16 | #  include <gnutls/crypto.h>
>       |            ^~~~~~~~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/888e9e252821bda1e051400d4aa850cd082e8e76
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Thanks for working on this!

I don't immediately see the relationship between the failure without
gnutls and the patches, which are about "put support for MacOS/Win SSL
libs back".

> diff --git a/package/cups/0005-cups-hash.c-Put-support-for-MacOS-Win-SSL-libs-back.patch b/package/cups/0005-cups-hash.c-Put-support-for-MacOS-Win-SSL-libs-back.patch
> new file mode 100644
> index 0000000000..70e6975caa
> --- /dev/null
> +++ b/package/cups/0005-cups-hash.c-Put-support-for-MacOS-Win-SSL-libs-back.patch
> @@ -0,0 +1,379 @@
> +From c6cd5e9c10edc68caf6936a3d3274f758e9cd03d Mon Sep 17 00:00:00 2001
> +From: Zdenek Dohnal <zdohnal@redhat.com>
> +Date: Tue, 3 Oct 2023 13:59:40 +0200
> +Subject: [PATCH 1/2] cups/hash.c: Put support for MacOS/Win SSL libs back

Patches should be generated with git format-patch -N.

> +From 0dd97fcaeeb16ed836e8542d75e2396fb1d129d9 Mon Sep 17 00:00:00 2001
> +From: Zdenek Dohnal <zdohnal@redhat.com>
> +Date: Tue, 3 Oct 2023 14:39:33 +0200
> +Subject: [PATCH 2/2] cups/hash.c: LibreSSL version does not support several
> + hashes

Huh, there is a second patch in the same patch? Is it related to our
issue? If so, how?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot