From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libwebsockets: fix wolfssl build
Date: Fri, 5 Jan 2024 14:03:34 +0100 [thread overview]
Message-ID: <20240105140334.6ac1bbe4@windsurf> (raw)
In-Reply-To: <20231226221952.2006884-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Tue, 26 Dec 2023 23:19:52 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following wolfssl build failure raised since commit
> d6319d97a7864314088dcc6d1199f35029cfcecb:
>
> -- Checking for one of the modules 'wolfssl'
> CMake Error at lib/tls/CMakeLists.txt:79 (message):
> You must set LWS_WOLFSSL_LIBRARIES and LWS_WOLFSSL_INCLUDE_DIRS when
> LWS_WITH_WOLFSSL is turned on.
Ideally, in such cases, it would be nice to extend a little bit the
commit log to explain how the issue is resolved: "adding a patch that
does XYZ, and making the wolfssl dependency only trigger when
BR2_PACKAGE_WOLFSSL_ALL=y because ...".
> +Fixes:
> + - http://autobuild.buildroot.org/results/fe062b9f0b330e71309334d7605d64ea73761b59
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
The Upstream: tag was missing here. So I dug in the upstream repo, and
found that your fix had been merged, so I added a reference to it here.
Applied, thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-05 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 22:19 [Buildroot] [PATCH 1/1] package/libwebsockets: fix wolfssl build Fabrice Fontaine
2024-01-05 13:03 ` Thomas Petazzoni via buildroot [this message]
2024-01-12 18:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240105140334.6ac1bbe4@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox