Re: [Buildroot] [PATCH v2] package/swugenerator: add missing runtime dependencies

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Giulio,

Thanks for the v2!

On Tue, 26 Dec 2023 22:40:37 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
> 
> At the moment swugenerator package lacks host-openssl, host-gzip and
> host-zstd runtime dependency so let's add them to prevent swugenerator from
> failing to run.

I'm going to nitpick a bit (yes, I admit), but this commit log explains
what the commit does, not why it does it. The *why* is important. The
problem is not that swugenerator lacks host-openssl, host-gzip and
host-zstd.

The problem is that swugenerator can (apparently) use openssl, gzip and
zstd on the host (under which conditions?), and therefore we should add
host-openssl, host-gzip and host-zstd as runtime dependencies.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot