Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Yang Li <yang.li@amlogic.com>
Cc: Bernd Kuhls <bernd@kuhls.net>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/linux-firmware: add scripts for Amlogic
Date: Fri, 19 Jan 2024 12:23:42 +0100	[thread overview]
Message-ID: <20240119122342.6230902d@windsurf> (raw)
In-Reply-To: <20240119031503.2967130-1-yang.li@amlogic.com>

Hello,

On Fri, 19 Jan 2024 11:15:02 +0800
Yang Li <yang.li@amlogic.com> wrote:

> Add scripts for installing Amlogic firmware.
> 
> Signed-off-by: Yang Li <yang.li@amlogic.com>

Thanks for your contribution! See some comments below.

> ---
>  package/linux-firmware/linux-firmware.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
> index c09dbc523e..735d4b7e53 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -856,6 +856,12 @@ LINUX_FIRMWARE_FILES += v4l-cx23885-avcore-01.fw
>  # which is installed unconditionally
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)

This option does not exist. Probably you forgot to add some changes in
package/linux-firmware/Config.in?

Also, usually, our options are not per vendor, but more per device or
class of devices. Which devices are supported by those 2 bluetooth
firmware files?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-01-19 11:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19  3:15 [Buildroot] [PATCH] package/linux-firmware: add scripts for Amlogic Yang Li
2024-01-19 11:23 ` Thomas Petazzoni via buildroot [this message]
2024-01-19 12:33   ` yann.morin
2024-01-22  2:12     ` Yang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240119122342.6230902d@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yang.li@amlogic.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox