Re: [Buildroot] [PATCH v2 1/1] package/libxml-parser-perl: bump to version 2.47

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Kevin Cui <bh@bugs.cc>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/libxml-parser-perl: bump to version 2.47
Date: Mon, 5 Feb 2024 12:36:50 +0100	[thread overview]
Message-ID: <20240205123650.23b78a48@windsurf> (raw)
In-Reply-To: <20240129034403.10232-2-bh@bugs.cc>

On Mon, 29 Jan 2024 11:44:04 +0800
Kevin Cui <bh@bugs.cc> wrote:

> Signed-off-by: Kevin Cui <bh@bugs.cc>
> 
> ---
> Changes for v2:
>   - use real name in "From" and "Signed-off-by"
> ---
>  package/libxml-parser-perl/libxml-parser-perl.hash | 4 ++--
>  package/libxml-parser-perl/libxml-parser-perl.mk   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Thanks for your patch! You forgot to explain in the commit log why the
README file hash changed. It's important to look into this and provide
explanation in the commit log, as it's the very reason why we have
those hashes in the first place: to detect license changes and account
for them.

And it turns out that a separate LICENSE file got added in 2.47. But
(!) this new license file is wrong: it doesn't contain the right
license text. This was already seen by Debian, and reported upstream:
https://github.com/cpan-authors/XML-Parser/pull/99.

So I expanded significantly the commit log to explain all of this. See
the final commit at
https://gitlab.com/buildroot.org/buildroot/-/commit/7fd6473a2b8c4ca274bd8a3b53e55d6af5242f9a.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot