Re: [Buildroot] [PATCH 1/1] package/libzenoh-pico: fix or1k build

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, 10 Jan 2024 22:55:15 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure with or1k raises since the addition of
> the package in commit a96361901dcc7b962a0c43f163e97a2de65687f3:
> 
> /home/autobuild/autobuild/instance-1/output-1/build/libzenoh-pico-0.10.0-rc/src/link/endpoint.c: Assembler messages:
> /home/autobuild/autobuild/instance-1/output-1/build/libzenoh-pico-0.10.0-rc/src/link/endpoint.c:358: Error: unrecognized instruction `nop'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/fd0b2c666a1dc1537162d15b27743abd270243ed
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...001-Remove-nop-or-replace-with-macro.patch | 131 ++++++++++++++++++
>  package/libzenoh-pico/libzenoh-pico.mk        |   6 +
>  2 files changed, 137 insertions(+)
>  create mode 100644 package/libzenoh-pico/0001-Remove-nop-or-replace-with-macro.patch

Thanks a lot for this new patch. We discussed it with Arnout, and even
with this upstream patch the whole thing is still very messy. There
seems to be absolutely no reason for upstream to need this ZP_ASM_NOP
macro. So rather than piling bogus things on top of more bogus things,
I went ahead and applied a fix that just disables this package on or1k.
Ideally, we should explain to upstream that these asm("nop") are
useless.

Thanks for your work!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot