Re: [Buildroot] [PATCH] package/ifplugd: add option to override sysconfdir

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Alisa,

On Mon, 15 Jan 2024 17:27:44 +0300
Alisa Volk via buildroot <buildroot@buildroot.org> wrote:

> Add BR2_PACKAGE_IFPLUGD_SYSCONFDIR option to pass custom --sysconfdir argument.
> 
> Ifplugd init script is auto-generated with sysconfdir="etc/" by default.
> As a result path to ifplugd configuration file is hardcoded
> to /etc/ifplugd/ifplugd.conf.

Thanks a lot for your patch! However, looking at it, the --sysconfdir
option has no impact on the path to the ifplugd.conf file. This file is
sourced by the init script before starting ifplugd, as explained in the
ifplugd man page:

FILES
       /etc/ifplugd/ifplugd.conf: this file is sourced by the init
       script /etc/init.d/ifplugd and contains the interface to be
       monitored and the options to be used.

Looking at the code, the only file affected by the --sysconfdir option
is ifplugd.action, and the path to this file can be overridden at
runtime using:

       -r | --run= EXEC
              Specify program to execute when link status changes
              (default: /etc/ifplugd/ifplugd.action)

So, in the end, it looks like your patch is not needed, as the location
of both ifplugd.conf and ifplugd.action is runtime configurable.

BTW, the ifplugd package does not have a Buildroot init script, it
would be nice to add one, if you have some time of course :-)

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot