Re: [Buildroot] [PATCH 04/10] package/re2: propagate dependencies from libabseil-cpp

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sun, 28 Jan 2024 14:20:53 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Commit fc7606010e4e (package/re2: bump to version 2023.11.01) forgot to
> propagate the arch dependency from libabsel-cpp to re2, and transitively
> to its dependees, causing unmet dependencies warnings (unfortunately,
> not errors), such as:
> 
>     $ KCONFIG_SEED=0xCCB17344 make randconfig
>     WARNING: unmet direct dependencies detected for BR2_PACKAGE_LIBABSEIL_CPP
>       Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n] && BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS [=n]
>       Selected by [y]:
>       - BR2_PACKAGE_RE2 [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y]
> 
> Fix that, and propagate the dependency.
> 
> Note that qt5webengine depends on glibc, so that implies !static
> already.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Michael Nosthoff <buildroot@heine.tech>
> Cc: Julien Corjon <corjon.j@ecagroup.com>
> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/grpc/Config.in             | 2 +-
>  package/qt5/qt5webengine/Config.in | 1 +
>  package/re2/Config.in              | 8 ++++++--
>  3 files changed, 8 insertions(+), 3 deletions(-)

There was already a previous patch from Fabrice to fix this, so I
applied his patch
https://patchwork.ozlabs.org/project/buildroot/patch/20240118220422.167000-1-fontaine.fabrice@gmail.com/,
with some edits.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot