From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/tinymembench: force arm mode instead of Thumb mode
Date: Wed, 7 Feb 2024 16:47:41 +0100 [thread overview]
Message-ID: <20240207164741.1bad9b44@windsurf> (raw)
In-Reply-To: <20240114135446.1156025-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Sun, 14 Jan 2024 14:54:46 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> +# tinymembench has some assembly function that is not present in Thumb mode:
> +# Error: instruction not supported in Thumb16 mode -- `subs r1,r1,#16'
> +# so, we desactivate Thumb mode
> +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
> +TINYMEMBENCH_MAKE_OPTS += CFLAGS="$(TARGET_CFLAGS) -marm"
> +endif
Why don't we simply extend the existing patch in the same way? It's
just that new code has been added in main.c that isn't Thumb
compatible, so I think you could change:
#ifdef __arm__
to
#if defined(__arm__) && defined(__ARM_ARCH_ISA_ARM)
in main.c, and this should get you going. Could you try this instead?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-02-07 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 13:54 [Buildroot] [PATCH v2, 1/1] package/tinymembench: force arm mode instead of Thumb mode Fabrice Fontaine
2024-02-07 15:47 ` Thomas Petazzoni via buildroot [this message]
2024-02-07 20:48 ` Fabrice Fontaine
2024-02-08 10:52 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207164741.1bad9b44@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox