From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Knight <james.d.knight@live.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] elfutils: drop lfs tweak
Date: Sun, 11 Feb 2024 23:08:27 +0100 [thread overview]
Message-ID: <20240211230827.3d820fe5@windsurf> (raw)
In-Reply-To: <CYYP221MB11409B6225528EC480F68A11A0442@CYYP221MB1140.NAMP221.PROD.OUTLOOK.COM>
On Thu, 8 Feb 2024 11:55:30 -0500
James Knight <james.d.knight@live.com> wrote:
> When the elfutils package was first introduced, it filtered out
> LFS-related compiler flags due to issues with the package's
> implementation. This package has since evolved over the years to support
> LFS (e.g. using `AC_SYS_LARGEFILE` [1]).
>
> Filtering out `-D_FILE_OFFSET_BITS=64` can lead to a configuration error
> when `BR2_TIME_BITS_64` is enabled:
>
> checking whether gcc supports -Wl,-z,relro... yes
> checking for __thread support... no
> configure: error: __thread support required
> ...
>
> With the configuration log providing the specific reason:
>
> configure:7175: .../output-1/host/bin/m68k-buildroot-linux-gnu-gcc -o conftest -fPIC -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_TIME_BITS=64 -Ofast -g0 -D_FORTIFY_SOURCE=2 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_TIME_BITS=64 -shared -Wl,-z,defs -Wl,-z,relro -latomic -Wl,--build-id conftest.c >&5
> In file included from .../output-1/host/m68k-buildroot-linux-gnu/sysroot/usr/include/features.h:394,
> from .../output-1/host/m68k-buildroot-linux-gnu/sysroot/usr/include/bits/libc-header-start.h:33,
> from .../output-1/host/m68k-buildroot-linux-gnu/sysroot/usr/include/stdlib.h:26,
> from conftest.c:13:
> .../output-1/host/m68k-buildroot-linux-gnu/sysroot/usr/include/features-time64.h:26:5: error: #error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
> 26 | # error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
> | ^~~~~
> configure:7175: $? = 1
> ...
>
> Fixes:
> - http://autobuild.buildroot.org/results/fbfe131673ed78999a07dbc879436e0ef6a8a1c0
>
> [1]: https://sourceware.org/git/?p=elfutils.git;a=commit;h=3425454a10d307fae891fb667cf7969e945cde79
>
> Signed-off-by: James Knight <james.d.knight@live.com>
> ---
> package/elfutils/elfutils.mk | 4 ----
> 1 file changed, 4 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-02-11 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 16:55 [Buildroot] [PATCH 1/1] elfutils: drop lfs tweak James Knight
2024-02-11 22:08 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240211230827.3d820fe5@windsurf \
--to=buildroot@buildroot.org \
--cc=james.d.knight@live.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox