From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
To: buildroot@buildroot.org
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Christian Stewart <christian@aperture.us>
Subject: [Buildroot] [PATCH 1/1] Revert "package/crun: allow building with uClibc"
Date: Tue, 13 Feb 2024 22:05:23 +0100 [thread overview]
Message-ID: <20240213210523.166319-1-fontaine.fabrice@gmail.com> (raw)
This reverts commit 223596c75d73a7eb29152235d3c5d9bf53bd58f5 indeed
fexecve is only available since
https://github.com/wbx-github/uclibc-ng/commit/858ffad217076227089cc17eb832db0bd1497792
resulting in the following build failure with uclibc < 1.0.33:
/home/thomas/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arceb-snps-linux-uclibc/9.2.1/../../../../arceb-snps-linux-uclibc/bin/ld: libcrun_testing.a(libcrun_testing_a-cloned_binary.o): in function `ensure_cloned_binary':
/home/thomas/autobuild/instance-3/output-1/build/crun-1.8.4/src/libcrun/cloned_binary.c:540: undefined reference to `fexecve'
Fixes: 223596c75d73a7eb29152235d3c5d9bf53bd58f5
- http://autobuild.buildroot.org/results/9c4488d5d26e575f39bcbaed8e0793ed1cdb8cd5
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/crun/Config.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/crun/Config.in b/package/crun/Config.in
index f6a1ec7c66..bbed21817e 100644
--- a/package/crun/Config.in
+++ b/package/crun/Config.in
@@ -1,8 +1,9 @@
config BR2_PACKAGE_CRUN
bool "crun"
depends on BR2_USE_MMU # fork()
+ depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
- select BR2_PACKAGE_ARGP_STANDALONE if !BR2_TOOLCHAIN_USES_GLIBC
+ select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_MUSL
select BR2_PACKAGE_YAJL # libocispec
help
crun is a fast and low-memory OCI Container Runtime in C.
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2024-02-13 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 21:05 Fabrice Fontaine [this message]
2024-07-22 20:42 ` [Buildroot] [PATCH 1/1] Revert "package/crun: allow building with uClibc" Thomas Petazzoni via buildroot
2024-07-25 13:14 ` Alexey Brodkin via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213210523.166319-1-fontaine.fabrice@gmail.com \
--to=fontaine.fabrice@gmail.com \
--cc=buildroot@buildroot.org \
--cc=christian@aperture.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox