From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/efivar: bump to version 39 to fix build failures
Date: Sun, 3 Mar 2024 23:19:12 +0100 [thread overview]
Message-ID: <20240303231912.76c9702f@windsurf> (raw)
In-Reply-To: <20240303171115.1140763-1-ju.o@free.fr>
Hello Julien,
On Sun, 3 Mar 2024 18:11:15 +0100
Julien Olivain <ju.o@free.fr> wrote:
> Those failures were introduced in commit f24029b561 "package/efivar:
> bump to version 38". This is because efivar introduced a usage of the
> qsort_r() libc function, in upstream commit [6], first included in
> version 38.
>
> Musl libc added the qsort_r() function in upstream commit [7],
> included in version v1.2.3 (2022-04-07). So external toolchains
> including a Musl older than this version will fail.
>
> This commit fixes those build failures by adding a dependency on
> !BR2_TOOLCHAIN_EXTERNAL_MUSL. Technically, this dependency also
> excludes external Musl toolchain _with_ the qsort_r() function, but
> there is currently no way to check that.
I think we shouldn't do that. Instead we should update/change the musl
toolchain used in the test-pkg testing. Possibly by using a Bootlin
toolchain instead.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-03-03 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 17:11 [Buildroot] [PATCH 1/1] package/efivar: bump to version 39 to fix build failures Julien Olivain
2024-03-03 22:19 ` Thomas Petazzoni via buildroot [this message]
2024-03-04 7:31 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240303231912.76c9702f@windsurf \
--to=buildroot@buildroot.org \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox