Re: [Buildroot] [PATCH 2/2] package/zic: enable installation on target

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Christian,

On Tue, 26 Mar 2024 17:03:20 +0100
christian@klarinett.li wrote:

> > Thanks, but for a patch like this, we definitely need a non-empty
> > commit log. Why do you need zic on the target, what is the use-case?  
> 
> When we configure a time zone on our device's GUI we use the standard
> time zones. This gives us the usual benefits e.g. automatic daylight
> saving time switching.
> We also need to support an API that wants to set the "time zone" by
> specifying the offset in minutes from GMT. The given information
> is not enough to reliably selecting one of the existing time zones.
> Instead, when the time zone is set over this API we dynamically create
> and configure a "Custom" time zone with the given offset. For this
> we use the `zic` tool on target.

Thanks for the explanation. I'm not too familiar with time zone stuff
(or in fact, I did have a look a long time ago, but I forgot the
details of how it works), bu your explanation seems to make sense :-)

> >> +define ZIC_INSTALL_STAGING_CMDS
> >> +	$(INSTALL) -D -m 644 $(@D)/tzfile.h 
> >> $(TARGET_DIR)/usr/include/tzfile.h  
> > 
> > So just the header file is needed, no library is installed?  
> 
> Actually, this is not required at all. I'll drop it in v2.

OK, then you can drop ZIC_INSTALL_STAGING = YES as well.

> Thanks for the review. I'll update the patch and will send a v2.

Perfect, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot