From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Chin Huat Ang <chinhuat@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/uclibc: bump to version 1.0.47, add Y2038 config option
Date: Sat, 6 Apr 2024 23:37:01 +0200 [thread overview]
Message-ID: <20240406233701.036e7ca8@windsurf> (raw)
In-Reply-To: <20240406154308.3336009-1-chinhuat@gmail.com>
Hello Chin,
On Sat, 6 Apr 2024 23:43:08 +0800
Chin Huat Ang <chinhuat@gmail.com> wrote:
> +config BR2_UCLIBC_USE_TIME64
> + bool "Use 64-bit date and time functions (Y2038-ready)"
> + depends on !BR2_ARCH_IS_64
> + default n
> + help
> + Enabling this option for 32-bit targets will configure
> + uClibc with config UCLIBC_USE_TIME64=y which enables 64-bit
> + date and time handling to support date/time beyond Y2038.
Thanks a lot for your patch!
I don't think we should add a BR2_UCLIBC_USE_TIME64 option. Instead,
there is already a BR2_TIME_BITS_64, which enables 64-bit time_t for
glibc. It simply needs to be extended to also allow enabling 64-bit
time_t in uClibc.
Also, can I suggest that you split your change into two commits? One
bumping uClibc to 1.0.47, and one making it possible to configure it
with 64-bit time_t?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-04-06 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 15:43 [Buildroot] [PATCH] package/uclibc: bump to version 1.0.47, add Y2038 config option Chin Huat Ang
2024-04-06 21:37 ` Thomas Petazzoni via buildroot [this message]
2024-04-07 17:47 ` Chin Huat Ang
2024-04-07 19:30 ` Arnout Vandecappelle via buildroot
2024-04-07 21:11 ` Thomas Petazzoni via buildroot
2024-04-09 12:23 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240406233701.036e7ca8@windsurf \
--to=buildroot@buildroot.org \
--cc=chinhuat@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox