Re: [Buildroot] [PATCH 0/3] package/pppd: fix pppd startup with upstream patches

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Alexis,

On Fri, 29 Mar 2024 15:31:35 +0100
Alexis Lothoré via buildroot <buildroot@buildroot.org> wrote:

> The issue has already been detected and fixed upstream (see [1]) and is
> expected to be released on a v2.5.1, but this release seems to be stalled
> for now (see [2]). A mere bump of the package is then not currently
> possible, so I am proposing a pick of the 3 relevant patches to fix this
> startup issue, both for master and 2024.02.x

Thanks for this set of patches. However, the way you formatted the
patches is not quite what we expect.

We expect you to:

 (1) git cherry-pick the commits

 (2) Add an Upstream: tag at the end of the commit message, following
     by your Signed-off-by line

 (3) Use "git format-patch -N" to format the 3 patches

Right now you have more or less "wrapped" the patches into commits you
are the author of, and your Signed-off-by line is missing.

Look at package/waylandpp/0001-add-missing-cstdint-include.patch for an
example of a properly formatted patch. Sergei Trofimovich is the
original author, Bernd Kuhls is the person who brought the patch into
Buildroot.

Could you rework your patch series accordingly?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot