Re: [Buildroot] [PATCH] package: linux-firmware: update linux fw bluetooth package for rtl88xx

From: "Gero Schwäricke" <gero.schwaericke@posteo.de>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package: linux-firmware: update linux fw bluetooth package for rtl88xx
Date: Wed, 17 Apr 2024 21:10:17 +0000	[thread overview]
Message-ID: <20240417211017.GA3300@Apollo> (raw)
In-Reply-To: <f76b797d-b9f3-4a40-bc99-8ef057b9aaeb@mind.be>

Hi Arnout,

On Wed, Apr 10, 2024 at 10:06:08AM +0200, Arnout Vandecappelle via buildroot wrote:
> 
> On 07/04/2024 22:38, Gero Schwäricke wrote:
[snip]
> > 
> > just saw this commit. In effect it added new firmware blobs for
> > rtl8821cs and rtl8852btu, but also removed one for rtl8852cu, was this
> > intentional?
> > 
> >    $ diff old new
> >    4a5,6
> >    > rtl8821cs_config.bin
> >    > rtl8821cs_fw.bin
> >    14a17,18
> >    > rtl8852btu_config.bin
> >    > rtl8852btu_fw.bin
> 
>  This is the purpose of the patch.
> 
> >    18d21
> >    < rtl8852cu_fw_v2.bin
> 
>  This is definitely not intentional. I clearly didn't test the patch enough
> before applying :-(
> 
>  Care to send a fix?  I think the easiest is to change the pattern to
> rtl88*.bin, but it needs to be verified.

I just send the patch. For testing I recorded the firmware package with

  tar --list --file output/build/linux-firmware-20240115/br-firmware.tar | sort > /tmp/.old  # and /tmp/.new

The diff is then

  $ diff /tmp/.old /tmp/.new 
  22a23
  > rtl_bt/rtl8852cu_fw_v2.bin

Seems to work as intended.

I noticed though that due to the new globbing approach the kconfig help
string is outdated. I'll send that as a separate patch.

Best,
Gero

> 
>  Regards,
>  Arnout
> 
> > 
> > Best,
> > Gero
[snip]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot