From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Ricardo Martincoski <ricardo.martincoski@datacom.com.br>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] utils/check-package: new check for Buildroot's defconfig files
Date: Wed, 1 May 2024 21:51:27 +0200 [thread overview]
Message-ID: <20240501215127.2d729695@windsurf> (raw)
In-Reply-To: <20240331203403.815497-1-yann.morin.1998@free.fr>
On Sun, 31 Mar 2024 22:34:03 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Now that we do have support for checking hashes for custom versions
> (for the few packages for which we do support custom versions, like the
> kernel, some bootloaders...), we want to ensure that our defconfig
> files, when they enable one or more such custom version, do enable
> checking the hashes for those versions, and thus we want to require all
> our defconfigs do enable BR2_DOWNLOAD_FORCE_CHECK_HASHES.
>
> Add a check for that condition.
>
> We need to be careful that we only check Buildroot's defconfig, whether
> in-tree or in a br2-external, and not kernel or other kconfig-based
> defconfig files, like those in board/ sub-directories. So we only match
> defconfig files that are in a configs/ directory, whether at the
> toplevel (for in-tree defconfigs), or not (for br2-external defconfigs).
>
> Since we only have two defconfigs that check hashes for custom versions,
> regnerate .checkpackageignore to ignore all so-far broken defconfigs.
>
> Suggested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Ricardo Martincoski <ricardo.martincoski@datacom.com.br>
>
> ---
> Note: this patch does not contain a regenerated .checkpackageignore, for
> ease of review; I can resubmit with it regenerated after reviews, or a
> committer may regenerate when applying.
> ---
> utils/check-package | 9 +++++++++
> utils/checkpackagelib/lib_defconfig.py | 20 ++++++++++++++++++++
> 2 files changed, 29 insertions(+)
> create mode 100644 utils/checkpackagelib/lib_defconfig.py
Applied to master, after updating .checkpackageignore of course. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-05-01 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 20:34 [Buildroot] [PATCH] utils/check-package: new check for Buildroot's defconfig files Yann E. MORIN
2024-05-01 19:51 ` Thomas Petazzoni via buildroot [this message]
2024-05-16 9:27 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501215127.2d729695@windsurf \
--to=buildroot@buildroot.org \
--cc=ricardo.martincoski@datacom.com.br \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox