Re: [Buildroot] [PATCH v1 1/8] package/libsoup3: fix reference to atomic

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Sat, 20 Apr 2024 20:58:46 +0200
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
> collect2: error: ld returned 1 exit status
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/4fb9f4c49777dde3abc30bb9f324816d3ed87567
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

I think this whole patch series is not the right way to fix the
problem. Indeed, what's using libatomic here is libglib2, and with your
solution, you have to chase down *all* reverse dependencies of libglib2.

Instead, what I'd like to see is that the glib-2.0.pc (pkg-config) file
gets updated to include -latomic in the Libs.private flags, so that it
gets automatically picked up by all reverse dependencies of libglib2
when they are static linking.

This also brings the advantage that you're not linking say libsoup3
directly with libatomic, like you're doing with your patch. Instead, in
a dynamic linking case, we keep on having libsoup3 linked just with
libglib2, and libglib2 linked with libatomic. It's only in the static
linking case that when we're building a final executable that uses
libsoup3, we need to also bring libatomic.a into the mix.

Could you have a look at fixing glib-2.0.pc instead?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot