Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libglib2: fix atomic handling
Date: Thu, 2 May 2024 10:31:39 +0200	[thread overview]
Message-ID: <20240502103139.62ca4812@windsurf> (raw)
In-Reply-To: <20230917185116.182810-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sun, 17 Sep 2023 20:51:16 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Correctly fix atomic handling to avoid the following build failure with
> all users of libglib2 (e.g. gdk-pixbuf) raised since bump to version
> 2.76.1 in commit 3f9622fe3d85b4d9f734b879abc1d485afea19b2:
> 
> /usr/lib/libglib-2.0.a(gthread-posix.c.o): in function `g_mutex_trylock':
> gthread-posix.c:(.text+0xda8): undefined reference to `__atomic_compare_exchange_4'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/24a358869b98d83ab374c7c3a185ced450064d35
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  .../0004-link-with-latomic-when-needed.patch  | 45 +++++++++++++++++++
>  package/libglib2/libglib2.mk                  |  5 ---
>  2 files changed, 45 insertions(+), 5 deletions(-)
>  create mode 100644 package/libglib2/0004-link-with-latomic-when-needed.patch

Applied to master, thanks. However, could you follow-up with upstream?
They re-opened a MR at
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3606 but then had
to close it because it broke the build in some situations. If you could
have a look and submit a new iteration of the patch upstream, it'd be
nice.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-05-02  8:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-17 18:51 [Buildroot] [PATCH 1/1] package/libglib2: fix atomic handling Fabrice Fontaine
2024-05-02  8:31 ` Thomas Petazzoni via buildroot [this message]
2024-05-21 20:12 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240502103139.62ca4812@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox