From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A634AC25B10 for ; Mon, 6 May 2024 20:02:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 717CF80DD5; Mon, 6 May 2024 20:02:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id atvb3yR417I1; Mon, 6 May 2024 20:02:52 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 862D28213E Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 862D28213E; Mon, 6 May 2024 20:02:52 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 02CF81BF3CA for ; Mon, 6 May 2024 20:02:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E056C6066F for ; Mon, 6 May 2024 20:02:49 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id LufqEWtH3BHe for ; Mon, 6 May 2024 20:02:49 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=217.70.183.200; helo=relay7-d.mail.gandi.net; envelope-from=thomas.petazzoni@bootlin.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org D3D53608BE DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D3D53608BE Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by smtp3.osuosl.org (Postfix) with ESMTPS id D3D53608BE for ; Mon, 6 May 2024 20:02:48 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 032D720003; Mon, 6 May 2024 20:02:45 +0000 (UTC) Date: Mon, 6 May 2024 22:02:44 +0200 To: Fabrice Fontaine Message-ID: <20240506220244.720638ca@windsurf> In-Reply-To: <20240505190044.1246330-1-fontaine.fabrice@gmail.com> References: <20240505190044.1246330-1-fontaine.fabrice@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: thomas.petazzoni@bootlin.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715025766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkqT6yORFIqKl4u+Okel+rxfUxXEamA2fOyD40GNTVU=; b=Xf0CQh+xyyOmPGW7uMbLp/Axp+CUQsuQXBYovYpShpf3CDXzTTxUg+7w4cBE/+cWSD2PXX 5yWJvmm//YH63bx+MKPfIzFH342lEEgXsNLHN71rW5XPvTY99gS8OkwhGJk9DGNuSuch59 Cj2TKxShXsoEBpeUV+AwjgY0DFIh3orUghF1CG9DL9Rz02cXqn8gRJ3qbk9SPbqYf8NwXR vob2t4b3Jphm+pflQqqFdfyNiVM7vgDlXA0kKBU9S+iQakAz/+NQgcsJsrWsZnKgGYxD9G HrYNo1wK5lFO4eje/91ydWl4VX6ZAPxE+aFS4ymZRyRg4U1AKWvmzZEAZ3P/ug== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Xf0CQh+x Subject: Re: [Buildroot] [PATCH v2, 1/1] package/libutempter: do not hardcode PIE X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Petazzoni via buildroot Reply-To: Thomas Petazzoni Cc: Adam Duskett , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" On Sun, 5 May 2024 21:00:44 +0200 Fabrice Fontaine wrote: > PIE will be set by buildroot if the user wants it so set > {COMPILE,LINK}_PIE to an empty value to fix the following build failure > raised since the addition of the package in commit > 02c818bc5c7a6967a212f12e4caa8ccdfa0b452b: > > /home/buildroot/autobuild/run/instance-3/output-1/host/bin/m68k-linux-gcc -W -Wall -Waggregate-return -Wcast-align -Wconversion -Wdisabled-optimization -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wwrite-strings -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g0 -std=gnu99 -DLIBEXECDIR=\"/usr/lib\" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wl,-z,relro -Wl,-stats -fPIE -pie -Wl,-z,now utempter.c -o utempter > > [...] > > /home/buildroot/autobuild/run/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/m68k-buildroot-linux-uclibc/12.3.0/../../../../m68k-buildroot-linux-uclibc/bin/ld: /home/buildroot/autobuild/run/instance-3/output-1/host/m68k-buildroot-linux-uclibc/sysroot/usr/lib/Scrt1.o: in function `lib_main': > (.text+0x4): undefined reference to `__shared_flat_add_library' > > Fixes: 02c818bc5c7a6967a212f12e4caa8ccdfa0b452b > - http://autobuild.buildroot.org/results/3a5581fd4edf56bbdc48ab111a2351fc70f1c703 > > Signed-off-by: Fabrice Fontaine > --- > Changes v1 -> v2 (after review of Yann E. Morin): > - Also set COMPILE_PIE Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot