From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Romain Naour <romain.naour@smile.fr>
Cc: Antoine Coutant <antoine.coutant@smile.fr>,
James Hilliard <james.hilliard1@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/python-rpds-py: bump to version 0.18.1
Date: Tue, 7 May 2024 09:12:44 +0200 [thread overview]
Message-ID: <20240507091244.45d6b5ba@windsurf> (raw)
In-Reply-To: <20240506213038.418213-1-romain.naour@smile.fr>
On Mon, 6 May 2024 23:30:38 +0200
Romain Naour <romain.naour@smile.fr> wrote:
> As reported by Antoine Coutant on the Buildroot mailing list [1]:
>
> rpds depends on the crate pyo3. This crate uses
>
> "std::sync::atomic::AtomicI64"
>
> which doesn't exist for 32 bits targets.
> That leads to an error as reported by Buildroot Gitlab-ci.
>
> An issue have been opened on pyo3's github [2].
> A fix have been accepted by pyo3 [3] and merged in pyo3 0.20.3 release
> [4]. This pyo3 0.20.3 uses crate portable-atomic [5] to provide atomic
> types and compare and swap operations for all targets that can use std.
>
> python-rpds-py 0.18.1 is the first release that use pyo3 0.20.3.
>
> Before python-rpds-py 0.18.1 release fixing this issue would require
> that we be able to patch a package during the Cargo vendoring step [6].
>
> [1] http://lists.busybox.net/pipermail/buildroot/2024-February/684867.html
> [2]: https://github.com/PyO3/pyo3/issues/3614
> [3]: https://github.com/PyO3/pyo3/pull/3619
> [4]: https://github.com/PyO3/pyo3/blob/v0.20.3/CHANGELOG.md
> [5]: https://github.com/taiki-e/portable-atomic
> [6]: http://lists.busybox.net/pipermail/buildroot/2024-February/684886.html
>
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/6783811842 (TestPythonPy3Dtschema)
> https://gitlab.com/buildroot.org/buildroot/-/jobs/6783811860 (TestPythonPy3FlaskExpectsJson)
>
> Reported-by: Antoine Coutant <antoine.coutant@smile.fr>
> Cc: James Hilliard <james.hilliard1@gmail.com>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
> package/python-rpds-py/python-rpds-py.hash | 2 +-
> package/python-rpds-py/python-rpds-py.mk | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-05-07 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 21:30 [Buildroot] [PATCH] package/python-rpds-py: bump to version 0.18.1 Romain Naour
2024-05-07 7:12 ` Thomas Petazzoni via buildroot [this message]
2024-05-27 15:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507091244.45d6b5ba@windsurf \
--to=buildroot@buildroot.org \
--cc=antoine.coutant@smile.fr \
--cc=james.hilliard1@gmail.com \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox