Re: [Buildroot] [PATCH v2 2/2] package/python3: drop unnecessary patches

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue,  7 May 2024 11:29:36 -0500
Vincent Fazio <vfazio@gmail.com> wrote:

> Patches 0004 and 0009 relied upon environment variables that were used
> to drive custom logic in distutils when executed by an external Python
> interpreter. This issue should have been mostly addressed upstream [0],
> but even if that was not the case, distutils is no longer a supported
> installation method for packages to use for installation as of 09de823c.
> As such, there shouldn't be a need to continue to patch it as setuptools
> vendors its own distutils that supercedes the one provided by Python.
> 
> Patches 0010 and 0026 (see [1] [2] [3]) can be removed due to a fix
> introduced in 3.7 [4].
> 
> Patch 0028 can be dropped since commit 3fed4245 removed the dependency
> on a host provided python to build host-python3.
> 
> [0] https://github.com/python/cpython/commit/9731330d6f4d63d6d57c8e99c8d11ef1def42858
> [1]: https://github.com/python/cpython/issues/67096
> [2]: https://github.com/python/cpython/issues/75894
> [3]: https://github.com/python/cpython/issues/66338
> [4]: https://github.com/python/cpython/commit/14086cfc5eed8c5e78342d79e5db87a135d75fa8
> 
> Signed-off-by: Vincent Fazio <vfazio@gmail.com>
> ---
> Changes v1 -> v2:
>   - reworded rationale for 0004 and 0009
> ---
>  .checkpackageignore                           |  5 --
>  ...y-header-paths-for-cross-compilation.patch | 69 -------------------
>  ...e-shebang-of-Python-scripts-for-cros.patch | 35 ----------
>  ...ig.sh.in-ensure-sed-invocations-only.patch | 67 ------------------
>  ...thon-config.sh-don-t-reassign-prefix.patch | 53 --------------
>  ...-fix-building-on-older-distributions.patch | 47 -------------
>  6 files changed, 276 deletions(-)
>  delete mode 100644 package/python3/0004-Adjust-library-header-paths-for-cross-compilation.patch
>  delete mode 100644 package/python3/0009-Do-not-adjust-the-shebang-of-Python-scripts-for-cros.patch
>  delete mode 100644 package/python3/0010-Misc-python-config.sh.in-ensure-sed-invocations-only.patch
>  delete mode 100644 package/python3/0026-python-config.sh-don-t-reassign-prefix.patch
>  delete mode 100644 package/python3/0028-fix-building-on-older-distributions.patch

Applied to master, thanks. I have also applied a follow-up patch that
renumbers the remaining patches and refreshes them so they apply
cleanly with "git am".

Thanks for all this work on the python3 integration, this is really
great!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot