Re: [Buildroot] [PATCH] Config.in: add option to ban textrels

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Fri, 19 Apr 2024 16:52:50 +0200
J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:

> Ideally, this option would default to yes when a musl-based toolchain is
> used, as musl doesn't support TEXTRELs[1] and programs with TEXTRELs
> will crash on start-up under musl.
> 
> However, to avoid a large build fallout, it defaults to "no" for now.
> After this option has been enabled in build tests for a while and some
> of the fallout has been fixed, the default can be changed.
> 
> [1]: https://www.openwall.com/lists/musl/2020/09/25/4
> 
> Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>

Thanks for the patch. I am not fully sure I totally grasp the issue,
but I'm wondering if making it an option is really the right thing to
do. If indeed TEXTRELs don't work with musl, then we should simply
disable them.

One thing I'm not entirely clear is that
https://www.openwall.com/lists/musl/2020/09/25/4 states "I recently
discovered that musl doesn't support DT/DF_TEXTREL in the main
executable", while passing -z text will disallow TEXTREL everywhere,
not only "main executable" but also shared libraries. Is that intended?

Do you have an idea of the amount of breakage enabling -z text would
cause? Which particular package/situation did you encounter that was
using TEXTREL and shouldn't have in order to be compatible with musl?

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot