Re: [Buildroot] [PATCH 1/1] package/gst1-plugins-good: add qt5tools as a dependency

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Charles Hardin <ckhardin@gmail.com>
Cc: Jens Zettelmeyer <zettelmeyerj@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gst1-plugins-good: add qt5tools as a dependency
Date: Thu, 9 May 2024 17:57:06 +0200	[thread overview]
Message-ID: <20240509175706.6b757c5d@windsurf> (raw)
In-Reply-To: <20240417181322.36344-2-ckhardin@gmail.com>

Hello Charles,

On Wed, 17 Apr 2024 11:13:22 -0700
Charles Hardin <ckhardin@gmail.com> wrote:

> During a configuration with per-package, seeing the following
> meson build error which is resolved when the qt5tools are
> declared explicitly as a dependency.
> 
>     build/gst1-plugins-good-1.22.9/ext/qt/meson.build:48:4: \
>       ERROR: Problem encountered: qt5 qmlglsink plugin is enabled, \
>       but qt specific tools were not found
> 
> Signed-off-by: Charles Hardin <ckhardin@gmail.com>
> ---
>  package/gstreamer1/gst1-plugins-good/Config.in            | 1 +
>  package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)

Thanks for your patch. I am able to reproduce the issue with the
following defconfig (please always include a defconfig that exhibits
the bug when submitting a bug fix):

BR2_aarch64=y
BR2_cortex_a72=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_GSTREAMER1=y
BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL=y
BR2_PACKAGE_GST1_PLUGINS_GOOD=y
# BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AVI is not set
# BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ISOMP4 is not set
# BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_WAVPARSE is not set
BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_QMLGL=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_OPENGL_EGL=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_QT5=y
BR2_PACKAGE_WAYLAND=y
# BR2_TARGET_ROOTFS_TAR is not set

But the thing is that even after applying your patch, the issue still
occurs (I re-did a full build from scratch to be sure). I do see
qt5tools being built/installed, but the build of gst1-plugins-good
still fails with:

output/build/gst1-plugins-good-1.22.9/ext/qt/meson.build:48:4: ERROR: Problem encountered: qt5 qmlglsink plugin is enabled, but qt specific tools were not found

The last line of the meson logs look like this:

Got pkg-config variable host_bins : /home/thomas/buildroot/buildroot/output/host/bin
Run-time dependency qt5 (modules: Core) found: YES 5.15.11 (pkg-config)
Program /home/thomas/buildroot/buildroot/output/host/bin/moc found: YES 5.15.11 5.15.11 (/home/thomas/buildroot/buildroot/output/host/bin/moc)
Program /home/thomas/buildroot/buildroot/output/host/bin/uic found: YES 5.15.11 5.15.11 (/home/thomas/buildroot/buildroot/output/host/bin/uic)
Program /home/thomas/buildroot/buildroot/output/host/bin/rcc found: YES 5.15.11 5.15.11 (/home/thomas/buildroot/buildroot/output/host/bin/rcc)
Program /home/thomas/buildroot/buildroot/output/host/bin/lrelease found: NO
Program lrelease5 found: NO
Program lrelease-qt5 found: NO
Program lrelease found: NO found  but need: '== 5.15.11' (/usr/bin/lrelease)

Based on this and my testing, it seems like not only
BR2_PACKAGE_QT5TOOLS=y is needed, but also
BR2_PACKAGE_QT5TOOLS_LINGUIST_TOOLS=y, so I've applied your patch with
this additional fix.

Also, the issue has nothing to do with per-package builds, it can be
reproduced without.

See the final commit at:

  https://gitlab.com/buildroot.org/buildroot/-/commit/c107dd33e679becf8b58d78d088b5320734d3e31

Thanks again!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot