From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Chris Packham <judge.packham@gmail.com>,
Thomas Devoogdt <thomas.devoogdt@barco.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1] package/syslog-ng: bump to 4.7.1
Date: Thu, 9 May 2024 18:18:58 +0200 [thread overview]
Message-ID: <20240509181858.6db00f5e@windsurf> (raw)
In-Reply-To: <20240422175944.449122-1-thomas@devoogdt.com>
Hello Thomas,
On Mon, 22 Apr 2024 19:59:44 +0200
Thomas Devoogdt <thomas@devoogdt.com> wrote:
> From: Thomas Devoogdt <thomas.devoogdt@barco.com>
Thanks for the patch!
> diff --git a/package/syslog-ng/Config.in b/package/syslog-ng/Config.in
> index aa1e71d225..c06a7221bf 100644
> --- a/package/syslog-ng/Config.in
> +++ b/package/syslog-ng/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_SYSLOG_NG
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_USE_MMU # fork()
> depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> + select BR2_PACKAGE_JSON_C
When you add a new select like this, you need to be careful. Indeed, if
the option you're selecting has some "depends on", you need to
replicate them in your package. Here, JSON_C has a "depends on
BR2_TOOLCHAIN_HAS_SYNC_4", which needs to be replicated:
index aa1e71d225..1302e6ac46 100644
--- a/package/syslog-ng/Config.in
+++ b/package/syslog-ng/Config.in
@@ -4,6 +4,8 @@ config BR2_PACKAGE_SYSLOG_NG
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU # fork()
depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c
+ select BR2_PACKAGE_JSON_C
select BR2_PACKAGE_LIBGLIB2
select BR2_PACKAGE_PCRE2
select BR2_PACKAGE_OPENSSL
@@ -16,5 +18,6 @@ config BR2_PACKAGE_SYSLOG_NG
comment "syslog-ng needs a toolchain w/ wchar, threads"
depends on BR2_USE_MMU
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
I fixed that up when applying. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-05-09 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 17:59 [Buildroot] [PATCH v1] package/syslog-ng: bump to 4.7.1 Thomas Devoogdt
2024-05-09 16:18 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509181858.6db00f5e@windsurf \
--to=buildroot@buildroot.org \
--cc=judge.packham@gmail.com \
--cc=thomas.devoogdt@barco.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas@devoogdt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox