From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: <nick.whitlock@eizo.com>
Cc: yann.morin.1998@free.fr, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/nvidia-driver: bump version to 550.78
Date: Thu, 9 May 2024 23:27:26 +0200 [thread overview]
Message-ID: <20240509232726.54ff0818@windsurf> (raw)
In-Reply-To: <TY2PR01MB4572A27ADF9451486BA9889084E62@TY2PR01MB4572.jpnprd01.prod.outlook.com>
Hello Nick,
On Thu, 9 May 2024 21:16:36 +0000
<nick.whitlock@eizo.com> wrote:
> > We need your patch to have your Signed-off-by line, otherwise we unfortunately cannot apply it.
>
> Is this mentioned somewhere in the documentation? I'm not sure how to apply this.
See
https://buildroot.org/downloads/manual/manual.html#submitting-patches.
Extract from this:
Finally, the patch should be signed off. This is done by adding
Signed-off-by: Your Real Name <your@email.address> at the end of the
commit message. git commit -s does that for you, if configured
properly. The Signed-off-by tag means that you publish the patch
under the Buildroot license (i.e. GPL-2.0+, except for package
patches, which have the upstream license), and that you are allowed
to do so. See the Developer Certificate of Origin for details.
So for once, our documentation does have the relevant details :-)
> > Why does this have a depends on BR2_PACKAGE_NVIDIA_DRIVER_MODULE ?
> > From what I can see in your patch, this option is merely installing
> > more user-space libraries, so why do you make this depend on the
> > driver module being enabled?
>
> Those libraries depend on the driver module, from my understanding.
What makes you think this?
> > - Are these hashes provided by some authoritative source upstream?
> > If
> so, indicate where. Otherwise, keeping the locally calculated sha256
> is sufficient.
>
> To my knowledge, I'm not sure. I computed them locally using
> `md5sum`, `sha1sum` and `sha256sum` and they seemed to take when I
> built it.
Then, only include the sha256, this is enough.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-05-09 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 19:00 [Buildroot] [PATCH] package/nvidia-driver: bump version to 550.78 Nick Whitlock
2024-05-09 19:51 ` Thomas Petazzoni via buildroot
2024-05-09 21:16 ` nick.whitlock
2024-05-09 21:27 ` Thomas Petazzoni via buildroot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-13 15:59 Nick Whitlock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509232726.54ff0818@windsurf \
--to=buildroot@buildroot.org \
--cc=nick.whitlock@eizo.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox