From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] configs/qemu_riscv32_nommu_virt_defconfig: New defconfig
Date: Sat, 11 May 2024 22:14:44 +0200 [thread overview]
Message-ID: <20240511221444.2b964158@windsurf> (raw)
In-Reply-To: <Zj8iP0Dx8Q/TWeNM@waldemar-brodkorb.de>
Hello Waldemar,
On Sat, 11 May 2024 09:46:07 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> Add new defconfig for Qemu RISCV32 w/o MMU.
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
Nice stuff!
Could you split this commit into two, one enabling RISC-V 32-bit noMMU,
and another adding the defconfig?
Also, in the patch adding the defconfig, fix the following
check-package warning:
WARNING: configs/qemu_riscv32_nommu_virt_defconfig:0: missing BR2_DOWNLOAD_FORCE_CHECK_HASHES
(we require this for new defconfigs)
Minor detail, the commit title should be:
configs/qemu_riscv32_nommu_virt: new defconfig
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-05-11 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 7:46 [Buildroot] [PATCH] configs/qemu_riscv32_nommu_virt_defconfig: New defconfig Waldemar Brodkorb
2024-05-11 20:14 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240511221444.2b964158@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox