Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Andreas Hilse via buildroot <buildroot@buildroot.org>
Cc: Andreas Hilse <andreas.hilse@gmail.com>,
	Andreas Hilse <andreas.hilse@googlemail.com>
Subject: Re: [Buildroot] [PATCH] linux-pam: add patch for spurious password expires in 0 days warning
Date: Mon, 13 May 2024 23:19:42 +0200	[thread overview]
Message-ID: <20240513231942.2dd93919@windsurf> (raw)
In-Reply-To: <20240327140125.154985-1-andreas.hilse@gmail.com>

Hello Andreas,

On Wed, 27 Mar 2024 15:01:25 +0100
Andreas Hilse via buildroot <buildroot@buildroot.org> wrote:

> Buildroot 2024.02 brings updated linux-pam 1.6.0 package which has a
> regression, that warns users about their password expiring in 0 days
> when logging in, even with password expiration not being active.
> There is no newer version released yet.
> Patch is working as intended, tested by me.
> 
> Patch taken from linux-pam PR: https://github.com/linux-pam/linux-pam/pull/744

The patch is now upstream, at
https://github.com/linux-pam/linux-pam/commit/470b5bdd8fd29d6b35e3a80f9a57bdd4b2438200

Could you adjust the commit title to:

	package/linux-pam: add patch for spurious password expires in 0 days warning

> diff --git a/package/linux-pam/0002-do-not-warn-if-password-aging.patch b/package/linux-pam/0002-do-not-warn-if-password-aging.patch
> new file mode 100644
> index 0000000000..7df83bf058
> --- /dev/null
> +++ b/package/linux-pam/0002-do-not-warn-if-password-aging.patch
> @@ -0,0 +1,27 @@
> +From 470b5bdd8fd29d6b35e3a80f9a57bdd4b2438200 Mon Sep 17 00:00:00 2001
> +From: Tobias Stoeckmann <tobias@stoeckmann.org>
> +Date: Fri, 19 Jan 2024 10:09:00 +0100
> +Subject: [PATCH] pam_unix: do not warn if password aging is disabled
> +
> +Later checks will print a warning if daysleft is 0. If password
> +aging is disabled, leave daysleft at -1.
> +
> +Resolves: https://github.com/linux-pam/linux-pam/issues/743
> +Fixes: 9ebc14085a3b ("pam_unix: allow disabled password aging")
> +Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>

and here, add:

Upstream: https://github.com/linux-pam/linux-pam/commit/470b5bdd8fd29d6b35e3a80f9a57bdd4b2438200

followed by your Signed-off-by line ?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-05-13 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 14:01 [Buildroot] [PATCH] linux-pam: add patch for spurious password expires in 0 days warning Andreas Hilse via buildroot
2024-05-13 21:19 ` Thomas Petazzoni via buildroot [this message]
2024-05-14  9:33   ` Andreas Hilse via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240513231942.2dd93919@windsurf \
    --to=buildroot@buildroot.org \
    --cc=andreas.hilse@gmail.com \
    --cc=andreas.hilse@googlemail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox