Re: [Buildroot] [PATCH v2 1/1] .github: add github action to automate PR handling

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Mon, 8 Jul 2024 10:25:05 +0800 (GMT+08:00)
DongdongZhang <zhangdongdong@eswincomputing.com> wrote:

> > Can probably just use a github script along these lines or something:
> > https://github.com/sbabic/swupdate/blob/2024.05.2/.github/workflows/contributing.yml
> > 
> > probably also needs a conditional so it only runs on the one github repo:
> > if: github.repository == ‘buildroot/buildroot’
> >   
> 
> Hi, James,
> In this scenario, I believe that using `dessant/repo-lockdown@v4` is more suitable 
> than `actions/github-script@v5`. `dessant/repo-lockdown@v4` is specifically focused 
> on repository lockdown functionality and has been widely used and validated. 
> In contrast, while `actions/github-script@v5` is flexible, it requires more 
> customization and maintenance work and a strong familiarity with JavaScript. 
> To keep the process simple and stable, I have decided to continue 
> using `dessant/repo-lockdown@v4`.

I do agree with you on this. However, you didn't reply to the second
comment from James, on checking that the action only runs on the main
buildroot repo, and not others. Indeed, we don't want people/companies
forking our repo to have this PR lockdown action triggered.

Could you check this, and send an updated version of your patch?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot