From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute via buildroot <buildroot@buildroot.org>
Cc: Fiona Klute <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH 1/1] package/network-manager: allow building with musl
Date: Mon, 8 Jul 2024 22:47:12 +0200 [thread overview]
Message-ID: <20240708224712.60433035@windsurf> (raw)
In-Reply-To: <20240708202117.3607581-1-fiona.klute@gmx.de>
Hello Fiona,
On Mon, 8 Jul 2024 22:21:17 +0200
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:
> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
>
> NetworkManager officially supports building with musl since version
> 1.30, so the restriction to glibc toolchain is no longer necessary.
>
> [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/4f7c04eaf94849d0455e97ba9bcfdd0b84e6459d/NEWS#L615
>
> Signed-off-by: Fiona Klute (WIWA) <fiona.klute@gmx.de>
Thanks, I've applied to master, with one small change, see below.
> - !BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS || \
> + !BR2_TOOLCHAIN_USES_GLIBC && !BR2_TOOLCHAIN_USES_MUSL || \
Changed to:
!(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL) || \
which to me feels the more natural opposite of:
depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-08 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 20:21 [Buildroot] [PATCH 1/1] package/network-manager: allow building with musl Fiona Klute via buildroot
2024-07-08 20:47 ` Thomas Petazzoni via buildroot [this message]
2024-07-11 10:11 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708224712.60433035@windsurf \
--to=buildroot@buildroot.org \
--cc=fiona.klute@gmx.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox