Re: [Buildroot] [PATCH v4 0/3] Refactor OpenSSH init.d script

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fiona,

On Tue, 9 Jul 2024 11:55:56 +0200
Fiona Klute <fiona.klute@gmx.de> wrote:

> The script is functional, but the use of long options was intentional
> for readability and I'd rather have it preserved. Having existing
> scripts in a hard-to-read style doesn't seem like a good reason not to
> be more explicit in new/updated ones [1]. That was the reason for the
> question (and patch) about which Busybox options I can rely on when
> writing init scripts.
> 
> Regarding the added "-q", if a start (stop) command fails because an
> instance is already running (not running) with the current version you
> only get "Starting sshd: FAIL", while with my version you'd see the
> *reason* in start-stop-daemon output. That seems important to me. I only
> had "-q" in the reload function because the "stopping" output of
> start-stop-daemon (when it's actually just sending a SIGHUP) seemed like
> it might confuse someone.

I'm fine with both, but then I think the documentation and the
canonical example it refers to should be fixed first. This is how we
declare what is the "right" way of doing things. Otherwise, we'll keep
on using these as a reference for all future scripts, and we don't have
a reference point that tells us how things should be done when fixing
existing scripts or adding new ones.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot