Re: [Buildroot] [PATCH v3 2/4] package/python-pyasynchat: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fiona,

On Tue,  9 Jul 2024 12:18:39 +0200
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:

> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
> 
> pyasynchat is a compatibility package that provides the asynchat
> module removed from the standard library in Python 3.12. It is needed
> to support fail2ban without a bundled copy and should be removed as
> soon as nothing in Buildroot depends on it.
> 
> Signed-off-by: Fiona Klute (WIWA) <fiona.klute@gmx.de>

I've also applied with some changes, see below.

> ---
>  package/Config.in                                |  1 +
>  package/python-pyasynchat/Config.in              | 11 +++++++++++
>  package/python-pyasynchat/python-pyasynchat.hash |  5 +++++
>  package/python-pyasynchat/python-pyasynchat.mk   | 15 +++++++++++++++
>  4 files changed, 32 insertions(+)

Added an entry in the DEVELOPERS file.


> diff --git a/package/python-pyasynchat/Config.in b/package/python-pyasynchat/Config.in
> new file mode 100644
> index 0000000000..bf11cc5b39
> --- /dev/null
> +++ b/package/python-pyasynchat/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_PYTHON_PYASYNCHAT
> +	bool "python-pyasynchat"
> +	select BR2_PACKAGE_PYTHON_PYASYNCORE # runtime

So here you declare this as a runtime dependency, which I believe is
correct.

> diff --git a/package/python-pyasynchat/python-pyasynchat.mk b/package/python-pyasynchat/python-pyasynchat.mk
> new file mode 100644
> index 0000000000..8bd87af5c4
> --- /dev/null
> +++ b/package/python-pyasynchat/python-pyasynchat.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# python-pyasynchat
> +#
> +################################################################################
> +
> +PYTHON_PYASYNCHAT_VERSION = 1.0.4
> +PYTHON_PYASYNCHAT_SOURCE = pyasynchat-$(PYTHON_PYASYNCHAT_VERSION).tar.gz
> +PYTHON_PYASYNCHAT_SITE = https://github.com/simonrob/pyasynchat/releases/download/v$(PYTHON_PYASYNCHAT_VERSION)
> +PYTHON_PYASYNCHAT_SETUP_TYPE = setuptools
> +PYTHON_PYASYNCHAT_LICENSE = Python Software Foundation License

Same nit: PSF-2.0 license.

> +PYTHON_PYASYNCHAT_LICENSE_FILES = LICENSE
> +PYTHON_PYASYNCHAT_DEPENDENCIES = python-pyasyncore

And here, you put python-pyasyncore as a build-time dependency, which
is inconsistent with the comment you wrote in the Config.in file. I
assumed it is a runtime dependency, like is the case for the vast
majority of dependencies between Python packages, so I just dropped
this line.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot