Re: [Buildroot] [RFC, 1/1] configs/am62x-sk: Add fragment for TI tree integration

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Paresh,

On Mon, 29 Apr 2024 14:53:26 +0530
Paresh Bhagat via buildroot <buildroot@buildroot.org> wrote:

> This commit introduces a new fragment config aimed at integration of TI trees
> into the existing configuration for am62x-sk. The fragment config is designed 
> to be merged with the current ti_am62x_sk_defconfig, enabling transition from 
> mainline to TI versions for U-boot and kernel.
> 
> The fragment config will be merged with existing ti_my_am62x_sk_defconfig
> using merge-config.sh script present in support/kconfig using following
> command.
> 
> ./support/kconfig/merge-config.sh configs/ti_am62x_sk_defconfig configs/ti_am62x_sk.config
> 
> It effectively changes uboot and kernel source from mainline version to TI 
> version hosted here
> 
> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/?h=ti-linux-6.1.y
> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/?h=ti-u-boot-2023.04
> 
> Furthermore, as ti-uboot 2023.04 is used, kernel Image and dtb is expected 
> in rootfs/boot/ and rootfs/boot/dtb/ti respectively. So add a new post-build
> script to copy these files to desired location. 
> 
> Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>

Thanks for the patch. What you're proposing here is something we don't
do for any other platform, at least in this form. I believe if we want
to do this, we probably wouldn't want a fragment, but rather a complete
separate defconfig instead.

We do have something somewhat similar though in the NXP world:

- freescale_imx6ullevk_defconfig is a defconfig for the i.MX6ULL EVK
  platform that uses the vendor-provided U-Boot/kernel

- imx6ullevk_defconfig is a defconfig for the same eval board, but that
  uses mainline U-Boot/kernel

So we could potentially do something similar if we wanted to.

Alternatively, for some ST platforms, we have a defconfig in Buildroot
mainline that use upstream TF-A/U-Boot/Linux, and a separate
buildroot-external-st BR2_EXTERNAL with defconfigs that use the ST
provided BSP. I'm not saying we should always do like this as I also
believe defconfigs using vendor-provided BSP might make sense in
upstream Buildroot.

I'm not sure how we want to standardize things here. Arnout, Peter,
Yann, Romain, any opinion?

> diff --git a/board/ti/common/am6xx/ti_arm64_prune.config b/board/ti/common/am6xx/ti_arm64_prune.config
> new file mode 100644
> index 0000000000..ad41cda81c
> --- /dev/null
> +++ b/board/ti/common/am6xx/ti_arm64_prune.config
> @@ -0,0 +1,485 @@
> +# Add config flags here that appear in the multi_v7_defconfig but are not

I'm confused by this comment. multi_v7_defconfig is an ARM32 kernel
config, and here we're targeting an ARM64 platform.


> diff --git a/boot/uboot/uboot.hash b/boot/uboot/uboot.hash
> index fbe5d21540..3baa2f5e2e 100644
> --- a/boot/uboot/uboot.hash
> +++ b/boot/uboot/uboot.hash
> @@ -1,3 +1,4 @@
>  # Locally computed:
>  sha256  b99611f1ed237bf3541bdc8434b68c96a6e05967061f992443cb30aabebef5b3  u-boot-2024.01.tar.bz2
>  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  Licenses/gpl-2.0.txt
> +sha256  5c3ce409901b8b16204b02d538833dcb6c66729c0316b53848d0f15642a49266  uboot-ti-u-boot-2023.04-br1.tar.gz

We clearly wouldn't want the hash of the TI-specific U-Boot in
boot/uboot/uboot.hash. Use the BR2_GLOBAL_PATCH_DIR feature to provide
your own hash files, specific to this defconfig.

> diff --git a/linux/linux.hash b/linux/linux.hash
> index 4fa9f701cd..9c0d26aa71 100644
> --- a/linux/linux.hash
> +++ b/linux/linux.hash
> @@ -17,3 +17,4 @@ sha256  b5539243f187e3d478d76d44ae13aab83952c94b885ad889df6fa9997e16a441  linux-
>  sha256  fb5a425bd3b3cd6071a3a9aff9909a859e7c1158d54d32e07658398cd67eb6a0  COPYING
>  sha256  f6b78c087c3ebdf0f3c13415070dd480a3f35d8fc76f3d02180a407c1c812f79  LICENSES/preferred/GPL-2.0
>  sha256  8e378ab93586eb55135d3bc119cce787f7324f48394777d00c34fa3d0be3303f  LICENSES/exceptions/Linux-syscall-note
> +sha256  3256bbd9eb9b3ffec10e8e013ed433e79adf83cf731677be7fcdd53e25d1db98  linux-ti-linux-6.1.y-br1.tar.gz

Same comment here for the Linux kernel.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot