From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C8EDC2BD09 for ; Tue, 9 Jul 2024 21:32:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2278F410D5; Tue, 9 Jul 2024 21:32:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3VGuGbagndBE; Tue, 9 Jul 2024 21:32:53 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D26A6410DB Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id D26A6410DB; Tue, 9 Jul 2024 21:32:52 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5916C1BF41D for ; Tue, 9 Jul 2024 21:32:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 456A0404BC for ; Tue, 9 Jul 2024 21:32:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PN06OlIGSvRM for ; Tue, 9 Jul 2024 21:32:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:4b98:dc4:8::223; helo=relay3-d.mail.gandi.net; envelope-from=thomas.petazzoni@bootlin.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org B32104042E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B32104042E Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by smtp2.osuosl.org (Postfix) with ESMTPS id B32104042E for ; Tue, 9 Jul 2024 21:32:50 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id C92C360006; Tue, 9 Jul 2024 21:32:47 +0000 (UTC) Date: Tue, 9 Jul 2024 23:32:46 +0200 To: Yang Li Message-ID: <20240709233246.4026b6f8@windsurf> In-Reply-To: <20240702121745.3445375-1-yang.li@amlogic.com> References: <20240702121745.3445375-1-yang.li@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: thomas.petazzoni@bootlin.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1720560768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GwRhlsK25Yb+0nLQ8GT4KkAJyRXqa3mLQAMkX4oMsNo=; b=icyppau1XIHpNxw60jRxfmpMfa0s4+m5TO7W7NgcNpTSAPtV7HVTcKSwOqHofnU1Rol9uA kwul2wSjG6hPB18dXUx03rbB/f0DVdd+B69Ce+ktAeVzaxe9+kmopRx641mrfKsPktUCMA ov6IcDOdZlGeQ1XOm2QAuZNGLnLpEXV9XabDXG2nc6Bo26GMSqwJn/Qa3PRDrr7a+uajwx /LU7Ae0gPFnhp7l2vTYME3ztjFXVER2+eFucap++1AzDv0MVzJZSCTBxIXHlwZbwlH9hds BwnQOuDWLgc+uZMwy447iK7trtcw/10Uw93N51sS1168+Nj1ceynBTexMHzKyQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=icyppau1 Subject: Re: [Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Petazzoni via buildroot Reply-To: Thomas Petazzoni Cc: bernd@kuhls.net, yann.morin.1998@free.fr, buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hello Yang, Thanks for your patch, which I have applied, after doing some changes, see below. On Tue, 2 Jul 2024 20:17:37 +0800 Yang Li wrote: > remove bluetooth subdirectory, and use generic pattern aml_* > to install all bluetooth binary. This commit log was not sufficient. It does not explain since when the bluetooth/ directory has been removed. This information is absolutely *critical* as it allows us to figure out whether this fix needs to be backported or not to previous version of Buildroot. Therefore, I have changed the commit log to: package/linux-firmware: change Amlogic Bluetooth binary path Since upstream commit 7d931f8afa51d83e9eaee3a3f449bc2f86a5edf3, which first appeared in linux-firmware 20240709, the amlogic bluetooth firmware files have been moved from amlogic/bluetooth/ to directly amlogic/. > # Amlogic SoC Bluetooth > ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y) > -LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin > +LINUX_FIRMWARE_FILES += amlogic/aml_* The change from *.bin to aml_* looked unnecessary. As far as I can see, all files still have a .bin extension, so this change looked gratuitous, and was not explained in the commit log. So I kept the *.bin for now. If needed a future commit can be made, with a proper explanation as to why aml_* is a better wildcard. Thanks! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot